From owner-freebsd-acpi@FreeBSD.ORG Thu Feb 26 15:36:16 2015 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9482A189 for ; Thu, 26 Feb 2015 15:36:16 +0000 (UTC) Received: from nm19-vm5.bullet.mail.ne1.yahoo.com (nm19-vm5.bullet.mail.ne1.yahoo.com [98.138.91.241]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BED07F8 for ; Thu, 26 Feb 2015 15:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1424964969; bh=vGhXhqxxOu6XRPlOcqfrLhh2e0Coz7sYnZalrff7sdw=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=IWvdw6pOPYvQMODcsTxvFio8fdQxBm1cpXwiaUM8k5ODpzZXvVlUWYfLpj7tv063JWWbTHroioiPdZUKbHuQ3sjlwvoc0uijuvTOzcvF/qsbnGK0nu0MKNuymo2cdAHXOWR+Ep5/jnBu/ArPQ+hJJe1u1ixSfQoxCvXHyncs27w= Received: from [98.138.226.176] by nm19.bullet.mail.ne1.yahoo.com with NNFMP; 26 Feb 2015 15:36:09 -0000 Received: from [98.138.84.47] by tm11.bullet.mail.ne1.yahoo.com with NNFMP; 26 Feb 2015 15:36:09 -0000 Received: from [127.0.0.1] by smtp115.mail.ne1.yahoo.com with NNFMP; 26 Feb 2015 15:36:09 -0000 X-Yahoo-Newman-Id: 88036.80543.bm@smtp115.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 6RT25sAVM1m81un04FJOiFfSGARCzeqJC0P5NeTYLshRVoP yqWV7in6Z5gkPI7j7Q0i.bpFqmh1KNfP7WtEjEAVcWegFmRxt3ywUumol2UG FszDUYIdQVJ88_oSytTs1guP90mWd6kj4ZzaQRZ.58kRnbRj_wzqYh84D6s9 C0tzfKecgXTbAKQsKVw4pMhRUpNowQwyJzindYtDgr14EGZ3Pbs1wOntCKj5 aM3oUVDLuN8WLV5eqq3zPctfWe.5TAYXqri9EXVyXJvmBWjPfQfBHeVZ24cZ VnquFUM0z_9fxkop5u.m6fMwsxYyoYn9RfWDeBSx55iZxmlBciQVx40t6vkz ttJFFwVHcxOKuDbDVY43iF3L0Bevywm9ePTmgsMs5bX5yjbjiut5AYPkZOzk gxYBpLZNfhRdBwbcZSdkUiSNwKJn24PieqLk_gOLhGom34gNgmXEw186OHGa MwZ7Ja0BAQsrmZjePAdComLT0Swhsk2S23NGOm7SdItT1Oqu3lwnG4BWyF.M Q1s5usParPKqvS6OyL39qA2sm2BEydWyO0wWtxU8JoJ9D5ySZ X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <54EF3D5D.4010106@att.net> Date: Thu, 26 Feb 2015 10:35:57 -0500 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: John Baldwin , freebsd-acpi@freebsd.org Subject: Re: No acpi_dell(4) References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> In-Reply-To: <2401337.2oUs7iAbtB@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 15:36:16 -0000 On 02/25/2015 02:53 PM, John Baldwin wrote: > On Monday, February 23, 2015 03:22:57 PM Anthony Jenkins wrote: >> On 02/22/2015 01:08 PM, hiren panchasara wrote: >>> I've just got a lightweight dell e7240 which is pretty nice with very >>> good batterylife. >>> >>> Only trouble is none of the buttons work. >>> >>> Is there any hackery people do to make them work? Time permitting, I'd >>> like to see if we can get something together which looks like acpi_ibm. >> Some machines throw acpi_wmi(4) events when those special buttons are >> pushed. Load acpi_wmi(4) driver and cat /proc/wmistat0. The WMI >> objects with hex numbers in the EVENT column *might* be for your keys. >> My HP Envy Sleekbook uses WMI for the radios key, but I haven't figured >> out how to get events for the LCD brightness control keys (although my >> brightness controls *do* work). I used a Linux driver as a reference tho... >> >> I'd like to make the acpi_wmi(4) interface easier to use, but my backlog >> of contributions I'm sitting on is only growing. > I've been waiting to see if you were going to post an update to rev 3 of your > CMOS patch after Ian's last round of feedback FWIW. Much of his feedback > seemed relevant (and I know you've already accepted some other rounds of > feedback on that patch before then, hence 'v3') > I am... I've just been stalling, mostly because it "works for me" and I didn't understand some of the critiques, particularly the "pessimization" one (over my head I think). I'll toss what I have out there for further review; I'll shoot for today or tomorrow. One of the things I felt I had to do in the CMOS handler was allow ACPI to perform multibyte accesses to the CMOS region, but the existing CMOS read/write functions were only byte accessors, and each byte access was locked. A multibyte access would lock, read/write a byte, unlock, lock, read/write a byte, unlock.... So I wrote multibyte accessors (which had some issues I think I corrected) and had the original RTC CMOS accessor functions call the multibyte ones. The multibyte accessors performed the locking, so a multibyte access would lock, read/write a byte, read/write a byte..., unlock. I believe one of the recommendations was to "put it back the way it was", which I did, along with failing any attempt by ACPIBIOS to access multiple bytes. I think the reason behind having an ACPI CMOS handler is to give the OS a say when ACPIBIOS wants to access CMOS, to prevent it from stepping on the toes of an RTC CMOS driver who's also twiddling CMOS registers and (presumably) knows the state of the device. Anthony