From owner-svn-src-all@FreeBSD.ORG Wed Sep 3 09:04:50 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F331D54; Wed, 3 Sep 2014 09:04:50 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5299E175F; Wed, 3 Sep 2014 09:04:48 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA10288; Wed, 03 Sep 2014 12:04:44 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1XP6Ue-000GLY-Ae; Wed, 03 Sep 2014 12:04:44 +0300 Message-ID: <5406D972.8010305@FreeBSD.org> Date: Wed, 03 Sep 2014 12:03:46 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Steven Hartland Subject: Re: svn commit: r270759 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs vm References: <201408281950.s7SJo90I047213@svn.freebsd.org> <39211177.i8nn9sHiCx@overcee.wemm.org> <201409021201.15967.jhb@freebsd.org> <5405F1F3.1@FreeBSD.org> <8AA1D02BB967468DA07731149E95390D@multiplay.co.uk> In-Reply-To: <8AA1D02BB967468DA07731149E95390D@multiplay.co.uk> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, John Baldwin , Peter Wemm , Alan Cox , svn-src-all@FreeBSD.org, Dmitry Morozovsky , "Matthew D. Fuller" , svn-src-head@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 09:04:50 -0000 on 02/09/2014 20:43 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" >> And the newly added kmem_foo() functions probably do not belong in >> cddl/compat/opensolaris as Solaris / illumos does not have those functions. > > They could be moved but their current location keeps all the kmem > related functions neatly in one place. Spreading them around IMO > would just make things hard to find. BTW, here is some of my old WIP that completely removed the pre-existing kmem_* functions and made the related code much closer to that in illumos. Unfortunately, I will now have hard time merging my changes with your change. https://github.com/avg-I/freebsd/compare/wip/hc/kmem_size-memguard-fix (esp.commits e0cf2f7 and becf087) >> I think that in this case e.g. vm_cnt.v_free_target can just be >> used directly by the FreeBSD-specific ARC code. > > It could but as above keeping everything in one place makes it to > find and hence MFC as this area has seen changes which will require > all those fields renamed. It also means if the logic for free pages > changes in the future there's only one place it needs to be changed. > > For those interested there's also an open review on additional > changes in this area: https://reviews.freebsd.org/D702 -- Andriy Gapon