From nobody Fri May 28 18:50:52 2021 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 11C8FC7F72C for ; Fri, 28 May 2021 18:50:58 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FsDKY4FSkz4X3K; Fri, 28 May 2021 18:50:56 +0000 (UTC) (envelope-from freebsd@grem.de) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 74a1d5dc; Fri, 28 May 2021 18:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=20180501; bh=gT/tfa8x pGMWOYKHJbXWapmvPBY=; b=tZDT96BpvDR83Bl3hB7a6d08caQBngZfg1Ra3PZd Sdb9LcpDyhi6KZWxP0cYcK/oiuqPqgOGAu1AVmdI+MfSrJYJFhhulYhwfPmPnjNV 7jaL1YYMUuay3KVg/gHWlfF8ZZIraFIbQGXmM5gRUgFtm0WyC+4Jq43AppOLFB0O xwe0Ehv5eyjCceVcauMOfg7EuAMYW82yh2za7NAG03vCoDv3OiD26Ss6mZRZFz9d yj+fypu4tGfUzqdTXFqdvWI8/lOYod/iMRHcx88bgTPwH2Lwoai9PN70ao5zA1VN pwnlpKCQ0vpxB8aq+PK8N5MQ4qRT7zLPlhbHiIEaC17Mkw== DomainKey-Signature: a=rsa-sha1; c=nofws; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=20180501; b=PE J1fpByXSg33Na2nor/rHdo0F+XYKFVZ5NAYFl7AltNPJgK5ggWN71lquzAEHEcss z1bRZ+rW1HZIHhCdJ/zkszC1xTqpWn15PEcVbHv52WhKh0BbaYJR+v19i1/Peb3P qr8saflp43fzCIIdvnVEADe2ABfrz0BAHn90FEObYxgQuEHfUxHF0YPVJrGwfKQD k8RATDh0ECQWgebSN6IupSxLrQSKdUxvY1gm8L06clkBKRun9ZdA6Yxq5dongn+8 zT7qFUy8BiIXchCMXprp+ZLoNRwOxputJMNEW7EJKa6KJMpkxG3T1jzFKrulp5kf f77jo21LdcFrMuxWujVA== Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id c4c25d9b (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Fri, 28 May 2021 18:50:54 +0000 (UTC) Date: Fri, 28 May 2021 20:50:52 +0200 From: Michael Gmelin To: Mathieu Arnold Cc: Michael Gmelin , Kurt Jaeger , current@freebsd.org Subject: Re: zpool upgrade and bootcode on 13-RELEASE Message-ID: <20210528205052.1c464a8f@bsd64.grem.de> In-Reply-To: <20210528183714.7xbmuouxlxxy3n6j@aching.in.mat.cc> References: <20210519153757.4e00e96f@bsd64.grem.de> <20210519193243.3fd82d19@bsd64.grem.de> <20210528183714.7xbmuouxlxxy3n6j@aching.in.mat.cc> X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FsDKY4FSkz4X3K X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Fri, 28 May 2021 20:37:14 +0200 Mathieu Arnold wrote: > On Wed, May 19, 2021 at 07:32:43PM +0200, Michael Gmelin wrote: > > > > > > On Wed, 19 May 2021 19:09:06 +0200 > > Kurt Jaeger wrote: > > > > > Hi! > > > > > > > Does this mean, re-installing the bootcode isn't necessary > > > > anymore > > > > - or has the warning been removed by accident/as a side effect > > > > of merging with OpenZFS? > > > > > > On the contrary, because of the switch from FreeBSD ZFS to > > > OpenZFS, the bootcodes needs to be updated! It's unfortunate > > > that no message is displayed 8-( > > > > > > > That's too bad - maybe it would make sense to mention this in the > > release errata? > > > > > The problem is, finding out which bootcode needs to go where etc. > > > > > > > For the machines in question it was a straightforward legacy > > layout, so that was easy enough (they came back up just fine - > > *phew*). > > > > Do you think there is any chance to get the warning back in there? > > Maybe in a more generic way, like: > > > > In case you're booting from , please make sure to update > > the bootcode according to your partition layout. See `man zfsboot' > > for details. > > > > Fun fact: That man page already exists (I had no idea), but could > > use some love - e.g., add the EFI examples you gave. > > I have had a look at that man page, it gives ten different commands, > without saying which you need to use, if they are all needed, or not, > or when you actually have to used them. > > Fun fact is that I absolutely never ever used any of them. All I ever > did was run: > > gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 ada1 > > because `zpool upgrade` told me to. It would probably be great to > have that command in that man page. > Hi Mathieu, I opened a pull request upstream. It already has been reviewed and accepted, but is yet to be merged: https://github.com/openzfs/zfs/pull/12104 The bootcode warning is now only shown for pools that have bootfs set (which should be fine on most "normal" installations) and reads like this: Pool 'testpool8' has the bootfs property set, you might need to update the boot code. See gptzfsboot(8) and loader.efi(8) for details. I figured that these are the most relevant man pages for current systems. It would make sense to update these man pages to be more helpful (latest, when this change lands in FreeBSD, but earlier obviously won't hurt). Best Michael -- Michael Gmelin