From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 9 22:30:22 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BDCE1338 for ; Tue, 9 Oct 2012 22:30:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id 8CC338FC23 for ; Tue, 9 Oct 2012 22:30:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q99MUMsr043598 for ; Tue, 9 Oct 2012 22:30:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q99MUMbX043597; Tue, 9 Oct 2012 22:30:22 GMT (envelope-from gnats) Resent-Date: Tue, 9 Oct 2012 22:30:22 GMT Resent-Message-Id: <201210092230.q99MUMbX043597@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Jeremy Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 53A631037 for ; Tue, 9 Oct 2012 06:28:19 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by mx1.freebsd.org (Postfix) with ESMTP id B0428904C3 for ; Tue, 9 Oct 2012 00:29:52 +0000 (UTC) Received: from server.rulingia.com (c220-239-248-178.belrs5.nsw.optusnet.com.au [220.239.248.178]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q990Towm033612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Oct 2012 11:29:51 +1100 (EST) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.14.5/8.14.5) with ESMTP id q990TiZX082860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Oct 2012 11:29:44 +1100 (EST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.14.5/8.14.5/Submit) id q990Timr082859; Tue, 9 Oct 2012 11:29:44 +1100 (EST) (envelope-from peter) Message-Id: <201210090029.q990Timr082859@server.rulingia.com> Date: Tue, 9 Oct 2012 11:29:44 +1100 (EST) From: Peter Jeremy To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/172542: [patch] FICL assumes standalone environment for testmain X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Peter Jeremy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2012 22:30:22 -0000 >Number: 172542 >Category: bin >Synopsis: [patch] FICL assumes standalone environment for testmain >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 09 22:30:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Peter Jeremy >Release: FreeBSD 8.3-STABLE amd64 >Organization: n/a >Environment: System: FreeBSD server.rulingia.com 8.3-STABLE FreeBSD 8.3-STABLE #18 r237444M: Sun Jul 8 10:47:08 EST 2012 root@server.rulingia.com:/var/obj/usr/src/sys/server amd64 >Description: When ficl is compiled as a userland program via "make testmain", loader.c reports a number of warnings (and -Wall adds more) because required header files are missing from the TESTMAIN case. A number of auto variables are also declared incorrectly relative to '#ifdef TESTMAIN' blocks. >How-To-Repeat: # cd /sys/boot/ficl # make testmain note warnings when compiling loader.c >Fix: Index: sys/boot/ficl/loader.c =================================================================== --- sys/boot/ficl/loader.c (revision 241347) +++ sys/boot/ficl/loader.c (working copy) @@ -34,10 +34,14 @@ #ifdef TESTMAIN #include +#include +#include +#include +#include #else #include +#include "bootstrap.h" #endif -#include "bootstrap.h" #include #include "ficl.h" @@ -135,9 +139,9 @@ ficlGetenv(FICL_VM *pVM) { #ifndef TESTMAIN - char *name; + char *name, *value; #endif - char *namep, *value; + char *namep; int names; #if FICL_ROBUST > 1 @@ -243,9 +247,9 @@ ficlFindfile(FICL_VM *pVM) { #ifndef TESTMAIN - char *name; + char *type, *name; #endif - char *type, *namep, *typep; + char *namep, *typep; struct preloaded_file* fp; int names, types; >Release-Note: >Audit-Trail: >Unformatted: