Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Apr 2015 14:29:44 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Garrett Cooper <ngie@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r282211 - head/tests/freebsd_test_suite
Message-ID:  <20150429112944.GI546@FreeBSD.org>
In-Reply-To: <201504290856.t3T8uuHF070908@svn.freebsd.org>
References:  <201504290856.t3T8uuHF070908@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote:
G> Author: ngie
G> Date: Wed Apr 29 08:56:56 2015
G> New Revision: 282211
G> URL: https://svnweb.freebsd.org/changeset/base/282211
G> 
G> Log:
G>   ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so the testcase
G>   no longer bombs out
G>   PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the testcase no
G>   longer bombs out if it prints to stderr
G>   
G>   MFC after: 5 days

This breaks buildworld since atf_skip() is a shell function, not a C one:

glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c
glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/
atf-sh/atf-sh.3:.Nm atf_skip ,

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150429112944.GI546>