From owner-svn-src-head@FreeBSD.ORG  Wed Apr 29 11:29:48 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C482A2AF;
 Wed, 29 Apr 2015 11:29:48 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 50DC911D3;
 Wed, 29 Apr 2015 11:29:47 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t3TBTiMY014420
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 29 Apr 2015 14:29:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t3TBTiSn014419;
 Wed, 29 Apr 2015 14:29:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 29 Apr 2015 14:29:44 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Garrett Cooper <ngie@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r282211 - head/tests/freebsd_test_suite
Message-ID: <20150429112944.GI546@FreeBSD.org>
References: <201504290856.t3T8uuHF070908@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504290856.t3T8uuHF070908@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2015 11:29:48 -0000

On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote:
G> Author: ngie
G> Date: Wed Apr 29 08:56:56 2015
G> New Revision: 282211
G> URL: https://svnweb.freebsd.org/changeset/base/282211
G> 
G> Log:
G>   ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so the testcase
G>   no longer bombs out
G>   PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the testcase no
G>   longer bombs out if it prints to stderr
G>   
G>   MFC after: 5 days

This breaks buildworld since atf_skip() is a shell function, not a C one:

glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c
glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/
atf-sh/atf-sh.3:.Nm atf_skip ,

-- 
Totus tuus, Glebius.