From owner-svn-ports-head@freebsd.org Sun Oct 6 06:48:13 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 27F3412EAD7; Sun, 6 Oct 2019 06:48:13 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46mDhY0HrLz3FK6; Sun, 6 Oct 2019 06:48:12 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7B7AD20EAA; Sun, 6 Oct 2019 02:48:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 06 Oct 2019 02:48:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=r8mUmo XA7in2LmmB0pAbYIGiPFCd85AUYkJJrichV+k=; b=NyN8Dr4mC7Rl7K0dqDE7jD sDPYb+VnZayw0nb0fNfO+zPfKjfbDxUbuxXhtADatgIp8DjVHpIBzE9oMEBH2ImT gv/PUo77a0t+LkwGTlGCEVGxVu1dmZMT4AV/zWaAT3uE7JDciZgV3+hoaGVPfDY0 axsl5LyPfXEOFvk4+sCMraP4pxiEaIRlhGlJg+2GG7xVT+gf3+Vzdal4RwW2aIee oucOmaOYsteCTXg7tPQsX7U4b+KKccuOLKHyznwxsyMXejCWOGFppZ/XQdSFnDZ3 lDw8pM8Mk6Mqt7AG6rdEFvBZN7j/M+fTb1M1RpI+mkua3B7EH44tgV+ylp/nl2KQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrheeggdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesghdtre ertderjeenucfhrhhomhepvfhosghirghsucfmohhrthhkrghmphcuoehtohgsihhksehf rhgvvggsshgurdhorhhgqeenucffohhmrghinhepfhhrvggvsghsugdrohhrghdpqhgvmh hurdhorhhgnecukfhppeelhedrledtrddvvdeirdduudenucfrrghrrghmpehmrghilhhf rhhomhepthhosghikhesfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpe dt X-ME-Proxy: Received: from urd.tobik.me (ip5f5ae20b.dynamic.kabel-deutschland.de [95.90.226.11]) by mail.messagingengine.com (Postfix) with ESMTPA id 8317A80059; Sun, 6 Oct 2019 02:48:11 -0400 (EDT) Date: Sun, 6 Oct 2019 08:48:09 +0200 From: Tobias Kortkamp To: Muhammad Moinur Rahman Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513844 - head/emulators/qemu Message-ID: <20191006064809.GA99162@urd.tobik.me> References: <201910052027.x95KRQoY068649@repo.freebsd.org> <20191006062141.GA45072@urd.tobik.me> <4093EC81-7A02-4DE9-AF83-9DBF45F6A99A@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk" Content-Disposition: inline In-Reply-To: <4093EC81-7A02-4DE9-AF83-9DBF45F6A99A@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46mDhY0HrLz3FK6 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2019 06:48:13 -0000 --UugvWAfsgieZRqgk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 06, 2019 at 12:25:21PM +0600, Muhammad Moinur Rahman wrote: > qemu has a slave port. So we are using USES?. But for qemu-utils or qemu-= guest-agent we just need USES=3Dxorg and nothing else. Adding USES=3Dxorg d= oesn=E2=80=99t work. :( It seems I have been unclear. USES?+=3D (note the extra +) does not do what you want and is a nop. It does not append to 'USES' but it appends to 'USES?' which is not right at all. $ make -C emulators/qemu -V 'USES?' xorg > > On 6 Oct, 2019, at 12:21, Tobias Kortkamp wrote: > >=20 > > On Sat, Oct 05, 2019 at 08:27:26PM +0000, Muhammad Moinur Rahman wrote: > >> Author: bofh > >> Date: Sat Oct 5 20:27:25 2019 > >> New Revision: 513844 > >> URL: https://svnweb.freebsd.org/changeset/ports/513844 > >>=20 > >> Log: > >> emulators/qemu: Update version 3.1.1=3D>3.1.1.1 > >>=20 > >> Modified: > >> head/emulators/qemu/Makefile > >> head/emulators/qemu/distinfo > >>=20 > >> Modified: head/emulators/qemu/Makefile > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/emulators/qemu/Makefile Sat Oct 5 18:52:36 2019 (r513843) > >> +++ head/emulators/qemu/Makefile Sat Oct 5 20:27:25 2019 (r513844) > >> @@ -2,7 +2,7 @@ > >> # $FreeBSD$ > >>=20 > >> PORTNAME=3D qemu > >> -PORTVERSION=3D 3.1.1 > >> +PORTVERSION=3D 3.1.1.1 > >> CATEGORIES=3D emulators > >> MASTER_SITES=3D https://download.qemu.org/ > >> DIST_SUBDIR=3D qemu/${PORTVERSION} > >> @@ -20,6 +20,7 @@ LIB_DEPENDS?=3D libnettle.so:security/nettle \ > >>=20 > >> .if !defined(PKGNAMESUFFIX) || (${PKGNAMESUFFIX} !=3D "-utils" && ${PK= GNAMESUFFIX} !=3D "-guest-agent") > >> ONLY_FOR_ARCHS=3D amd64 i386 powerpc powerpc64 > >> +USES?+=3D xorg > >=20 > > It is unfortunate that make(1) accepts this, but 'USES?+=3D' means > > 'append to a variable called USES?' which is probably wrong. What > > did you mean here? 'USES?=3D', 'USES+=3D' or maybe it should be removed > > again? At the moment this does not really do anything. >=20 --UugvWAfsgieZRqgk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2ZjiZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2GCvwgArpqzh653MGbt39Qe9df3CsijGriS9lyS605XiWEqYwq+D/b9Tm4LJ7Os dOHxL9AP2S9cDIqrMCXIN8y9mFQPSxk/zx5E30nSPc8Db2PtN2xRg8pf2IZaTFYe l88ZHm/Yt/ZOapQPgKpNweiKGYpOfi3fB8waNsW+A+dsIZQvRyYQJqygNt57yVX6 bOgwvI16BG8NFoZMamZ8GeSw9QqzsZ4d/94EWD7C1s49Pn0RO1q6B2zKYngoofzq lpe4lD8oSfTuOGd8+z70oOzPy1/6uV2iNEKM9GqfTNLHTPMcZIk495TrW9HJoqdo CrtdukVcYtIc9ibsVKGm6+gEgwC+pw== =YMd8 -----END PGP SIGNATURE----- --UugvWAfsgieZRqgk--