From owner-freebsd-current@FreeBSD.ORG Thu Dec 2 21:51:26 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A677816A4CE; Thu, 2 Dec 2004 21:51:26 +0000 (GMT) Received: from postman.ripe.net (postman.ripe.net [193.0.0.199]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33A1043D5E; Thu, 2 Dec 2004 21:51:26 +0000 (GMT) (envelope-from marks@ripe.net) Received: by postman.ripe.net (Postfix, from userid 8) id 9B013246D0; Thu, 2 Dec 2004 22:51:25 +0100 (CET) Received: from birch.ripe.net (birch.ripe.net [193.0.1.96]) by postman.ripe.net (Postfix) with ESMTP id 96F4D24654; Thu, 2 Dec 2004 22:51:24 +0100 (CET) Received: from ripe.net (cow.ripe.net [193.0.1.239]) by birch.ripe.net (8.12.10/8.11.6) with SMTP id iB2LpOLE026697; Thu, 2 Dec 2004 22:51:24 +0100 Received: (nullmailer pid 1983 invoked by uid 1001); Thu, 02 Dec 2004 21:51:23 -0000 Date: Thu, 2 Dec 2004 22:51:23 +0100 From: Mark Santcroos To: Poul-Henning Kamp Message-ID: <20041202215123.GA1512@laptop.6bone.nl> References: <200412012316.iB1NGcmu024834@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412012316.iB1NGcmu024834@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Handles: MS6-6BONE, MS18417-RIPE X-RIPE-Spam-Level: X-RIPE-Spam-Tests: ALL_TRUSTED,BAYES_00 X-RIPE-Spam-Status: N 0.000012 / -5.9 X-RIPE-Signature: 71756f56c269b583650694a44bf8b248 cc: current@freebsd.org Subject: VOP_* changes causes NULL ptr dereference for acl_get_file(3) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2004 21:51:26 -0000 I need at least the following patch to keep my system alive. A simple call to acl_get_file(3) is enough to crash the machine. You will have to think a bit more about how you want to initialize stuff or about better defaults for cases like ACLs. Mark ==== //depot/projects/custom/kern/vfs_default.c#35 - /home/marks/proj/perforce/projects/custom/kern/vfs_default.c ==== @@ -95,6 +95,7 @@ .vop_revoke = VOP_PANIC, .vop_strategy = vop_nostrategy, .vop_unlock = vop_stdunlock, + .vop_getacl = VOP_EINVAL, }; /* -- RIPE NCC - Delft University of Technology - The FreeBSD Project marks@ripe.net - m.a.santcroos@ewi.tudelft.nl - marks@freebsd.org