From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 28 09:00:42 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF99E16A4CE for ; Wed, 28 Jan 2004 09:00:42 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D8E743D45 for ; Wed, 28 Jan 2004 09:00:37 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0SH0bFR077815 for ; Wed, 28 Jan 2004 09:00:37 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0SH0btH077814; Wed, 28 Jan 2004 09:00:37 -0800 (PST) (envelope-from gnats) Resent-Date: Wed, 28 Jan 2004 09:00:37 -0800 (PST) Resent-Message-Id: <200401281700.i0SH0btH077814@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eric van Gyzen Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6A5116A4CE for ; Wed, 28 Jan 2004 08:59:46 -0800 (PST) Received: from trillian.vangyzen.net (trillian.client.intrex.net [209.42.213.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AF7243D45 for ; Wed, 28 Jan 2004 08:59:38 -0800 (PST) (envelope-from vangyzen@trillian.vangyzen.net) Received: from trillian.vangyzen.net (localhost.vangyzen.net [127.0.0.1]) by trillian.vangyzen.net (8.12.9/8.12.9) with ESMTP id i0SGxGrl075144; Wed, 28 Jan 2004 11:59:17 -0500 (EST) (envelope-from vangyzen@trillian.vangyzen.net) Received: (from vangyzen@localhost) by trillian.vangyzen.net (8.12.9/8.12.9/Submit) id i0SGx6Ig075139; Wed, 28 Jan 2004 11:59:06 -0500 (EST) Message-Id: <200401281659.i0SGx6Ig075139@trillian.vangyzen.net> Date: Wed, 28 Jan 2004 11:59:06 -0500 (EST) From: Eric van Gyzen To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: des@des.no Subject: bin/62036: src/libexec/ftpd/ftpd.c: local pam_handle_t shadows global X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Eric van Gyzen List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2004 17:00:43 -0000 >Number: 62036 >Category: bin >Synopsis: src/libexec/ftpd/ftpd.c: local pam_handle_t shadows global >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 28 09:00:37 PST 2004 >Closed-Date: >Last-Modified: >Originator: Eric van Gyzen >Release: FreeBSD 5.2-RELEASE i386 >Organization: >Environment: FreeBSD 5.2-RELEASE >Description: The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable pam_handle_t *pamh = NULL; which shadows the same variable in the global scope. This seems unintentional, because the global pamh is never initialized by pam_start(), so the other functions in ftpd.c always operate on a NULL pam_handle_t. >How-To-Repeat: N/A >Fix: Index: src/libexec/ftpd/ftpd.c =================================================================== RCS file: /build/cvsroot/src/libexec/ftpd/ftpd.c,v retrieving revision 1.147 diff -u -r1.147 ftpd.c --- src/libexec/ftpd/ftpd.c 15 Nov 2003 11:08:26 -0000 1.147 +++ src/libexec/ftpd/ftpd.c 28 Jan 2004 16:54:50 -0000 @@ -1238,7 +1238,6 @@ static int auth_pam(struct passwd **ppw, const char *pass) { - pam_handle_t *pamh = NULL; const char *tmpl_user; const void *item; int rval; >Release-Note: >Audit-Trail: >Unformatted: