From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 6 02:20:02 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FA6010656C7 for ; Fri, 6 Mar 2009 02:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EF2D38FC1C for ; Fri, 6 Mar 2009 02:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n262K1PO054931 for ; Fri, 6 Mar 2009 02:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n262K18e054930; Fri, 6 Mar 2009 02:20:01 GMT (envelope-from gnats) Resent-Date: Fri, 6 Mar 2009 02:20:01 GMT Resent-Message-Id: <200903060220.n262K18e054930@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rajesh Patel Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9B601065675 for ; Fri, 6 Mar 2009 02:16:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A7E8C8FC15 for ; Fri, 6 Mar 2009 02:16:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n262GgYj092008 for ; Fri, 6 Mar 2009 02:16:42 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n262GgWo092007; Fri, 6 Mar 2009 02:16:42 GMT (envelope-from nobody) Message-Id: <200903060216.n262GgWo092007@www.freebsd.org> Date: Fri, 6 Mar 2009 02:16:42 GMT From: Rajesh Patel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/132351: rijndael CBC mode encryption incorrect X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2009 02:20:02 -0000 >Number: 132351 >Category: kern >Synopsis: rijndael CBC mode encryption incorrect >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Mar 06 02:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Rajesh Patel >Release: 5.0 >Organization: >Environment: Windows XP professional - 32 bit >Description: The function has bug in CBC mode encryption int rijndael_blockEncrypt(cipherInstance *cipher, keyInstance *key, BYTE *input, int inputLen, BYTE *outBuffer) { Original code for (i = numBlocks - 1; i > 0; i--) { #if 1 /*STRICT_ALIGN*/ AF_BCOPY(outBuffer, block, 16); ========> ((word32*)block)[0] ^= ((word32*)iv)[0]; ((word32*)block)[1] ^= ((word32*)iv)[1]; ((word32*)block)[2] ^= ((word32*)iv)[2]; ((word32*)block)[3] ^= ((word32*)iv)[3]; #else ((word32*)block)[0] = ((word32*)outBuffer)[0] ^ ((word32*)input)[0]; ((word32*)block)[1] = ((word32*)outBuffer)[1] ^ ((word32*)input)[1]; ((word32*)block)[2] = ((word32*)outBuffer)[2] ^ ((word32*)input)[2]; ((word32*)block)[3] = ((word32*)outBuffer)[3] ^ ((word32*)input)[3]; #endif outBuffer += 16; rijndaelEncrypt(block, outBuffer, key->keySched, key->ROUNDS); input += 16; } This keeps using the same iv. As a result, the initial block is encrypted multiple times. input should be copied over iv inside the for loop. >How-To-Repeat: >Fix: Code with Fix for (i = numBlocks - 1; i > 0; i--) { #if 1 /*STRICT_ALIGN*/ AF_BCOPY(outBuffer, block, 16); /*needs this =======>*/ AF_BCOPY(input, iv, 16); /* Added by Rajesh */ ((word32*)block)[0] ^= ((word32*)iv)[0]; ((word32*)block)[1] ^= ((word32*)iv)[1]; ((word32*)block)[2] ^= ((word32*)iv)[2]; ((word32*)block)[3] ^= ((word32*)iv)[3]; #else ((word32*)block)[0] = ((word32*)outBuffer)[0] ^ ((word32*)input)[0]; ((word32*)block)[1] = ((word32*)outBuffer)[1] ^ ((word32*)input)[1]; ((word32*)block)[2] = ((word32*)outBuffer)[2] ^ ((word32*)input)[2]; ((word32*)block)[3] = ((word32*)outBuffer)[3] ^ ((word32*)input)[3]; #endif outBuffer += 16; rijndaelEncrypt(block, outBuffer, key->keySched, key->ROUNDS); input += 16; } >Release-Note: >Audit-Trail: >Unformatted: