From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 2 17:10:15 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22D0D1065674 for ; Tue, 2 Oct 2012 17:10:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D4BFF8FC15 for ; Tue, 2 Oct 2012 17:10:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q92HAEZJ091080 for ; Tue, 2 Oct 2012 17:10:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q92HAECo091075; Tue, 2 Oct 2012 17:10:14 GMT (envelope-from gnats) Resent-Date: Tue, 2 Oct 2012 17:10:14 GMT Resent-Message-Id: <201210021710.q92HAECo091075@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Daniel U. Thibault" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 007401065673 for ; Tue, 2 Oct 2012 17:00:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id BCC438FC18 for ; Tue, 2 Oct 2012 17:00:22 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q92H0M68067194 for ; Tue, 2 Oct 2012 17:00:22 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q92H0LWI067193; Tue, 2 Oct 2012 17:00:21 GMT (envelope-from nobody) Message-Id: <201210021700.q92H0LWI067193@red.freebsd.org> Date: Tue, 2 Oct 2012 17:00:21 GMT From: "Daniel U. Thibault" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/172279: OpenBSM-21/openbsm/libbsm/bsm_token.c au_to_process32_ex documentation is incorrect X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2012 17:10:15 -0000 >Number: 172279 >Category: misc >Synopsis: OpenBSM-21/openbsm/libbsm/bsm_token.c au_to_process32_ex documentation is incorrect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 02 17:10:14 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Daniel U. Thibault >Release: >Organization: DRDC Valcartier >Environment: >Description: The au_to_process32_ex function of bsm_token.c (a component of the current libbsm implementation) reads in part: /* [...] * machine address 16 bytes */ token_t * au_to_process32_ex(au_id_t auid, uid_t euid, gid_t egid, uid_t ruid, gid_t rgid, pid_t pid, au_asid_t sid, au_tid_addr_t *tid) { [...] if (tid->at_type == AU_IPv4) GET_TOKEN_AREA(t, dptr, sizeof(u_char) + 10 * sizeof(u_int32_t)); else if (tid->at_type == AU_IPv6) GET_TOKEN_AREA(t, dptr, sizeof(u_char) + 13 * sizeof(u_int32_t)); [...] if (tid->at_type == AU_IPv6) { ADD_MEM(dptr, &tid->at_addr[1], sizeof(u_int32_t)); ADD_MEM(dptr, &tid->at_addr[2], sizeof(u_int32_t)); ADD_MEM(dptr, &tid->at_addr[3], sizeof(u_int32_t)); } Clearly the token's size is variable, unlike what the preamble says. >How-To-Repeat: Look up http://www.opensource.apple.com/source/OpenBSM/OpenBSM-21/openbsm/libbsm/bsm_token.c and search for au_to_process32_ex. >Fix: Change the au_to_process32_ex preamble to conclude with: * machine address 4 bytes/16 bytes (depending on address type-len) */ >Release-Note: >Audit-Trail: >Unformatted: