From owner-cvs-src-old@FreeBSD.ORG Mon Sep 27 19:27:14 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81CD9106564A for ; Mon, 27 Sep 2010 19:27:14 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6FA358FC15 for ; Mon, 27 Sep 2010 19:27:14 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o8RJRE8B077791 for ; Mon, 27 Sep 2010 19:27:14 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o8RJREXE077790 for cvs-src-old@freebsd.org; Mon, 27 Sep 2010 19:27:14 GMT (envelope-from delphij@repoman.freebsd.org) Message-Id: <201009271927.o8RJREXE077790@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to delphij@repoman.freebsd.org using -f From: Xin LI Date: Mon, 27 Sep 2010 19:26:56 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet in_rmx.c src/sys/netinet6 in6_rmx.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2010 19:27:14 -0000 delphij 2010-09-27 19:26:56 UTC FreeBSD src repository Modified files: sys/netinet in_rmx.c sys/netinet6 in6_rmx.c Log: SVN rev 213225 on 2010-09-27 19:26:56Z by delphij Add a bandaid for a long-standing race condition during route entry un-expiring. The previous version of code have no locking when testing rt_refcnt. The result of the lack of locking may result in a condition where a routing entry have a reference count but at the same time have RTPRF_OURS bit set and an expiration timer. These would eventually lead to a panic: panic: rtqkill route really not free When the system have ICMP redirects accepted from local gateway in a moderate frequency, for instance. Commit this workaround for now until we have some better solution. PR: kern/149804 Reviewed by: bz Tested by: Zhao Xin, Pete French MFC after: 2 weeks Revision Changes Path 1.82 +3 -2 src/sys/netinet/in_rmx.c 1.48 +3 -1 src/sys/netinet6/in6_rmx.c