From owner-freebsd-current  Sat Feb  9 10: 2:24 2002
Delivered-To: freebsd-current@freebsd.org
Received: from muse.sanewo.dyn.to (p803c5f.tokyjk17.ap.so-net.ne.jp [211.128.60.95])
	by hub.freebsd.org (Postfix) with ESMTP id 5913037B419
	for <freebsd-current@freebsd.org>; Sat,  9 Feb 2002 10:02:18 -0800 (PST)
Received: from muse.sanewo.dyn.to (sanewo@localhost [127.0.0.1])
	by muse.sanewo.dyn.to (8.11.6/8.11.6) with ESMTP id g19I1w307461;
	Sun, 10 Feb 2002 03:01:59 +0900 (JST)
	(envelope-from sanewo@muse.sanewo.dyn.to)
Message-Id: <200202091801.g19I1w307461@muse.sanewo.dyn.to>
To: Munehiro Matsuda <haro@h4.dion.ne.jp>
Cc: Georg.Koltermann@mscsoftware.com, freebsd-current@freebsd.org,
	vsilyaev@mindspring.com
Subject: Re: /dev/rtc not configured message when starting VMWare2 on -current
References: <px8wuxpr4k9.wl@hunter.muc.macsch.com>
 <20020209002638L.haro@h4.dion.ne.jp>
Cc: Takanori Saneto <sanewo@ba2.so-net.ne.jp>
From: Takanori Saneto <sanewo@ba2.so-net.ne.jp>
In-Reply-To: <20020209002638L.haro@h4.dion.ne.jp>
 (Munehiro Matsuda's message of "Sat, 09 Feb 2002 00:26:38 +0900")
MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya")
Content-Type: text/plain; charset=ISO-2022-JP
User-Agent: T-gnus/6.15.5 (based on Oort Gnus v0.05) (revision 01)
 SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=)
 APEL/10.3 MULE XEmacs/21.5 (beta3) (asparagus) (i386-unknown-freebsd5.0)
Date: Sun, 10 Feb 2002 03:01:57 +0900
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Re: "Re: /dev/rtc not configured message when starting VMWare2 on -current"
In article <20020209002638L.haro@h4.dion.ne.jp>,
	Munehiro Matsuda <haro@h4.dion.ne.jp> wrote:
>I have a hack^Wpatch that should fix your problem.

I think you need to prevent returning the value of uninitialized
variable (``error'') when no error should be returned.

How about following patch? (just added "error = 0;" line)

Index: rtc.c
===================================================================
RCS file: /export/cvsup/cvs/ports/emulators/rtc/files/rtc.c,v
retrieving revision 1.6
diff -u -r1.6 rtc.c
--- rtc.c	16 Sep 2001 07:05:18 -0000	1.6
+++ rtc.c	9 Feb 2002 17:54:44 -0000
@@ -266,10 +266,32 @@
 {
 int error;
 
+#if __FreeBSD_version >= 500023
+dev_t dev;
+struct rtc_softc *sc;
+
+	if (rtc_sc!=NULL)
+		return (EINVAL);
+
+  	dev = make_dev(&rtc_cdevsw, 0, UID_ROOT, GID_WHEEL, 0644, DEVICE_NAME); 
+	if (dev==NULL)
+		return (EINVAL);
+
+	MALLOC(sc, struct rtc_softc*, sizeof(*sc), M_DEVBUF, M_WAITOK);
+	if (sc==NULL)
+		return (EINVAL);
+
+	bzero(sc, sizeof(*sc));
+	rtc_sc = sc;
+	dev->si_drv1 = sc; /* Link together */
+	sc->dev = dev;
+	error = 0;
+#else
    	error = cdevsw_add(&rtc_cdevsw);
 	if (error) 
 		return error;
 
+#endif
 	return error;
 }
 

-- 
さねを (SANETO Takanori)             // [趣味] 本業をすること //
・・・・・・・・・・・・・・・・・ //    Bonjour Chapeau     //
<URL:mailto:sanewo@ba2.so-net.ne.jp> // [本業] 趣味に走ること //

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message