From owner-cvs-all Tue Apr 2 11:40:19 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id 3500437B405; Tue, 2 Apr 2002 11:40:09 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020402194008.FWNP22231.rwcrmhc52.attbi.com@InterJet.elischer.org>; Tue, 2 Apr 2002 19:40:08 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA21618; Tue, 2 Apr 2002 11:22:54 -0800 (PST) Date: Tue, 2 Apr 2002 11:22:53 -0800 (PST) From: Julian Elischer To: Kenneth Culver Cc: Mike Barcroft , Matthew Dillon , "M. Warner Losh" , jake@locore.ca, dillon@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph In-Reply-To: <20020402100957.C45652-100000@alpha.yumyumyum.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2 Apr 2002, Kenneth Culver wrote: > > > if (a) { > > > x; > > > y; > > > } else > > > /* > > > * HITHERE! > > > */ > > > b; > > > > This looks better with proper 8 character tabs. I think in KNF extra > > braces are normally used in situations like this, but this is an edge > > case. > > 8 character tabs? why use tabs at all? That requires an > engineer/programmer to set that in an editor, and a lot of people don't > like having tabs that are that large... I just use spaces because then my > code will look the same as when I wrote it no matter what editor is used, > and no matter what the tabs are set to. Then your code would be different from all other code in FreeBSD. Code checeked in should be 8 character tabs.. this is one of the most BASIC requirements, even if some developers feel themselves too important to abide by it.. It is one of the first things that gives the BSD code base a unified appearance. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message