From nobody Wed Jan 21 19:51:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dxFFw0mtCz6PdwD for ; Wed, 21 Jan 2026 19:52:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dxFFv63nsz3JQb for ; Wed, 21 Jan 2026 19:52:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769025123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5aRlDXKFT3aaWEAme0DD9UJJOO85+OgyzYfNELesykw=; b=ACkBfesfxx24Eihg7QuEpR/Z4Im/Gczz+RMMJEglSxZVqt3zALEIPqZ4Fzj+PMBk1LBVmA ItUW/r/5Fz1mXDntKhnEb4HGgxTjtNyg5IeJ+ctlxqh6SGu7nL0Mto1vEZFUSghYAHVuh/ DgTz03NMnqoAtbhFvlMONmkhEONa+gIZv+g6Phg86Wcn/JNXBNQeQVSpaCchckMTG7ScNp yIVKFjClh0nKiyc/YCoHM10Yq8Bygn0d/jFZr/PiSqsoi+te2S9gux7ZY9/1JzgywABh9Z /EPPhT+kgMpaeTh7o+7JPgSK5COOJZXuJaIe+LuzObKpXKJfRwbStvwIP6jHyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769025123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5aRlDXKFT3aaWEAme0DD9UJJOO85+OgyzYfNELesykw=; b=feTg28O/UXYo9R33F7zsr/uVMCKWHAp2LTmqDl+DPJeAt2d8u8VsG1Co+pdyC4bU8nPy4y RHeZKULg8rw5fH6Caw39aOda+XWljS01Hjw6ISkCN5rFUQ91cQW5oQF9ddap5A567lpqhe X4vnPjOyz7/dMyfk3AGW2ebyuhNXSRhdHgrsnZ0bo4hJvEZioXhxcon13YATnJvZ806pbV eXUMtRRCZOPsBlNJ8kPDNUP5dF+497FAkksaU3EqAldM14LN1SKybQKWwVkOrCzuhJiI3n VNTHPXrdy3P02BE8Ktvee+2iFEqANqK4ab4MDTw2d1/AP59c0ddH01ygccZCLg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769025123; a=rsa-sha256; cv=none; b=e8Yw4/78j8NxZwj2tSNu9zYeKv6Gv1/7bHlvctKypbc06iSBQ/tndvbrCkGHKQkWtWXBjO b+kh8ci0mIPrsBy9StqkjOws1eBdKHcWnTCua7YEZhPRXOVPKX8D5qKU+Xtq0qTtIgBdF8 CdZjhVjg+/yDAgKJgc9ngTcN4YUmUFfxsboHamWc2yR/76PHAFBJkuONy/04Ho2688TtaQ 3BcpOnCO5eAqOciJ2Cxgy0MxA8IpLRHMjWDEeRsQDdMrQ/Ols2WPRCsOVuUAK+IPgNsmnG G7OaDHTa0AQQ42aa4UqZbk1Nh4C+lp3EEZJ4DtAnnGRMCLeCbamaUk6Nq4Jl+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dxFFv3lq2z11LL for ; Wed, 21 Jan 2026 19:52:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id bb18 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 21 Jan 2026 19:51:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: a148f7e54c4a - stable/15 - bge: disable TXCSUM if UDP transmit checksum offloading is disabled List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a148f7e54c4ac521d650a256126a0d33af4c2023 Auto-Submitted: auto-generated Date: Wed, 21 Jan 2026 19:51:58 +0000 Message-Id: <69712e5e.bb18.7c8511f4@gitrepo.freebsd.org> The branch stable/15 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=a148f7e54c4ac521d650a256126a0d33af4c2023 commit a148f7e54c4ac521d650a256126a0d33af4c2023 Author: Michael Tuexen AuthorDate: 2026-01-16 12:32:13 +0000 Commit: Michael Tuexen CommitDate: 2026-01-21 19:51:34 +0000 bge: disable TXCSUM if UDP transmit checksum offloading is disabled The bge interface is special with respect to transmit checksumi offloading. In the default settings, an bge interface announces TXCSUM capabilities, but only supports TCP/IPv4 and not UDP/IPv4 due to limitations of some of the NICs. This results in problems when the bge interface becomes a member of a bridge. Since currently only the TXCSUM capabilities are synced when a member is added to a bridge and not the protocol specific capabilities, this can result in a situation where UDP packets are sent out using a bge interface without having a correct checksum. To mitigate this problem, initially don't announce TXCSUM capabilities, when UDP transmit checksum is disabled. It is still possible to enable TXCSUM capabilities via ifconfig. PR: 291420 Reviewed by: Timo Voelker Differential Revision: https://reviews.freebsd.org/D54486 (cherry picked from commit bbd30927b1af44226c8de0512912a7fedfce2824) --- share/man/man4/bge.4 | 10 +++++++++- sys/dev/bge/if_bge.c | 14 +++++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/share/man/man4/bge.4 b/share/man/man4/bge.4 index de559c16df3c..fdf46fec0073 100644 --- a/share/man/man4/bge.4 +++ b/share/man/man4/bge.4 @@ -29,7 +29,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF .\" THE POSSIBILITY OF SUCH DAMAGE. .\" -.Dd August 18, 2017 +.Dd January 16, 2026 .Dt BGE 4 .Os .Sh NAME @@ -276,3 +276,11 @@ Also, due to the lack of hotplug support, Thunderbolt-based interfaces must not while the system is up as the kernel is currently unable to cope with a .Nm interface disappearing. +.Pp +The UDP transmit checksum offloading is disabled by default, see +.Va dev.bge.%d.forced_udpcsum . +To avoid problems when the interface is a member of a +.Xr bridge 4 +interface, all transmit checksum offloading is initially disabled in this case. +Transmit checksum offloading can be enabled using +.Xr ifconfig 8 . diff --git a/sys/dev/bge/if_bge.c b/sys/dev/bge/if_bge.c index cf3084f9b768..2feb19bff677 100644 --- a/sys/dev/bge/if_bge.c +++ b/sys/dev/bge/if_bge.c @@ -3721,7 +3721,12 @@ bge_attach(device_t dev) if_setgetcounterfn(ifp, bge_get_counter); if_setsendqlen(ifp, BGE_TX_RING_CNT - 1); if_setsendqready(ifp); - if_sethwassist(ifp, sc->bge_csum_features); + /* Initially enable checksum offloading either for all of IPv4, TCP/IPv4 + * and UDP/IPv4, or for none. This avoids problems when the interface + * is added to a bridge. + */ + if (sc->bge_csum_features & CSUM_UDP) + if_sethwassist(ifp, sc->bge_csum_features); if_setcapabilities(ifp, IFCAP_HWCSUM | IFCAP_VLAN_HWTAGGING | IFCAP_VLAN_MTU); if ((sc->bge_flags & (BGE_FLAG_TSO | BGE_FLAG_TSO3)) != 0) { @@ -3732,6 +3737,13 @@ bge_attach(device_t dev) if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWCSUM, 0); #endif if_setcapenable(ifp, if_getcapabilities(ifp)); + /* + * Disable TXCSUM capability initially, if UDP checksum offloading is + * not enabled. This avoids problems when the interface is added to a + * bridge. + */ + if ((sc->bge_csum_features & CSUM_UDP) == 0) + if_setcapenablebit(ifp, 0, IFCAP_TXCSUM); #ifdef DEVICE_POLLING if_setcapabilitiesbit(ifp, IFCAP_POLLING, 0); #endif