From nobody Wed Aug 3 17:37:09 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LyfFG34Fnz4YFT4 for ; Wed, 3 Aug 2022 17:37:22 +0000 (UTC) (envelope-from tezeka@hotmail.com) Received: from BRA01-CPZ-obe.outbound.protection.outlook.com (mail-cpzbra01olkn2012.outbound.protection.outlook.com [40.92.97.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LyfFD3LFwz42Ym; Wed, 3 Aug 2022 17:37:20 +0000 (UTC) (envelope-from tezeka@hotmail.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZxZiOdIl7gS64Jbp526giaJ/eqvovhtFXlAn38GeAY6QDrW+LNmnM4K4m7U2Sx/xpuVRwpRKqPUmbBfWIqzT8cpnEm4rUU4zj6HVGveBpKqpp2I2KqCGJQUi3hjTYs+hhK6oUVA1A2wsaPiBLa9XOAt+rpgQj2HW6sK0FXoRbihoiXM4XENq/6crYBksGffvgc3WB+5RbeA+WVQMPXLQoaXAT8lxjA5G5Pyig5F8IBsGRmC/mb46azvhpLFolSiu9btVKEGJU9DosEd/De3Uy83b7YGnpaA+hKLFyTUXIKFRCurfGu2WhWYmMaLWxV2ATpmp5+T0nUIZuR8Bfq5kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bzh9IuZiWPxYvQRN3lGDTvl9YlFppokeK/tNTKZ6+jg=; b=VPb+DbvbXBLT+BUaSu3I/eBb1CCfZ3HtceJE1ySD77jlBZHd3hI3ESKw800zq35Tp7kyS/HFjJx++kuYleSvw6TtRCA7Hn2WyuaJ13rIea3sYaEg86xUaMLfG9FrHb8+nXxj3gZaM0wBl8PNarK3vV9DWDScJOgYLuehiY5maXHN/HFhMDAv0zvrXid0tbGi4YkEwFm3xR4bNVaXGGkh5IDLMO3S1ltYPlfb1ZMEizsac1pj0Q59QR9a+NLVXfu7gVHzSHh0jVxl7+8d/60lBMgKugTFU+bP8l1KzmMs1PzMGvkmRcV7CWHqm5aznohWj0+B3QH3jwoeqKzO5p/0VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bzh9IuZiWPxYvQRN3lGDTvl9YlFppokeK/tNTKZ6+jg=; b=MqGzRn5xXo/aYohHhxEhuw1/cz30rH4JRDNoeOzbHJy3S1kIOtrrWeo7SXHJ4YWGYZ0PNT3R7/2pxsWV6s9U6Gh8vMsZwGwwRKMV6Phd7ucWTKfCNNKM6R7cN5A7xoLSfdhTmmxJK8AzXmJFIjsbepXHM/n2q+kkBRFmpIuFHxUcNY2RqeJZzktEYB4ET0t3J7ofsvu2qQb5hUIXRDwZb9+tiFRZaDZn6CnJ3c4K5VIJlZAYrNQAj/2yORHiJ0y5C2F5ZopyzoTr8yt+dnzL0owYaq8yUX6TROX8wKXjZRe7EnOU2g+MJk9IiDN+G2biXu552uS12YVMs2gZZJgQwA== Received: from CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:118::12) by CP4P284MB1585.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:108::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12; Wed, 3 Aug 2022 17:37:16 +0000 Received: from CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM ([fe80::8423:7f52:935f:65e2]) by CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM ([fe80::8423:7f52:935f:65e2%7]) with mapi id 15.20.5482.016; Wed, 3 Aug 2022 17:37:16 +0000 Date: Wed, 3 Aug 2022 14:37:09 -0300 (-03) From: Ivan Quitschal To: Ivan Quitschal cc: Hans Petter Selasky , Tomoaki AOKI , "freebsd-current@freebsd.org" , Kurt Jaeger Subject: Re: vt newcons 3 clicks mouse paste issue FIXED In-Reply-To: Message-ID: References: <41ef5c38-515f-739a-cb47-7cab0e609526@selasky.org> <20220623014847.067b18a5ba388639cf6009ce@dec.sakura.ne.jp> Content-Type: text/plain; charset=US-ASCII; format=flowed X-TMN: [DpeVdVblSVSbNcyiLI1Lh/7vsMB8XKNS] X-ClientProxiedBy: CP6P284CA0005.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:1aa::15) To CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:118::12) X-Microsoft-Original-Message-ID: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 999bdf05-9bf3-483d-d259-08da7576ceae X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNUisu3qrbEAqaAOdVId8I0rBzIkimuUt/e0VCpKwAweWdEO+F9130pLnL/xP9nHL+jx8WG6lH/LiInckpR2BuCH/HC4YE27x5g1KHD0giTS37G6gAKp3g2LZYQk+JKhhBEkwSf/++NUTdnyWKuutmng9ylfO2O0vKH5dQdhB+9WFllGvQWe8OE1nMlDmeh13qrP5/J3g0j/c/7dN1oi18SpLKLGwVjmf+0IEwVluvVJA+ovHn9KMa8JZGQTHPfHMtXQ0Dow5FpTIqdcAW1as3Rmep8fpNEzxfBRR5LbJRcTKXjq8YNmY77Yx4U7RGsjDdOR3z6tFnG128OShSCDYf3Tr7JqRymhvBZAj6FsRIdUl5b/amZcf8MC8Eyyfkdw0bu42TezS54uifjwAQRkllqoanmTHcIWoYApY2F+Qj+2IX+P4nP3hMufK4otlubdQjBCxSlVbnSD7+AAhrXvbVdQ0LdAxZid2oyj/WTqTP5RFKmAiBqFysR3afIyRVDFdOlR9moG08qspBu6JPSt/SQdlZJD31gHa2PIcEfR4w4Rr0rNqM2af5XdwnUWfh4tOHCGYUr07g1+2U3+m1gxQ/hlkQrc95byhG04BNdyf2KZ3ODYgVHsqQ/ns56kkt7n6Z+fzXYHbqKrAqfDDOTYrxJCrNC4QQyvJjMreevEkIjS4iOIC4Vy/zaWlKu+hZY6J2+GNKLxZ6wUs3khC8jhOL77S5tYBE8zZTA= X-MS-TrafficTypeDiagnostic: CP4P284MB1585:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZGclJ3XzHRZd0gOrdqTFsGLhp5kvwBvpXAYlNtaMr5dQoP68RK6qMzuv/OXH7+aUBFjGOGC/dFBa8/oXi9+miVIX1x5ThegoInCCXH/HGKiFgJuksdCipFrmpuYD0Puxtse+6UdrXVMyVuhBg6gnzUUaZV+fXafULwAop/qdhzkeMY+cpa9mVA9zBsjlHGZMllcH2fBp8XZNQsv1Msl6pDMEzDIJzuIYkUo/nAurxahoS4us/CyRMrcROklYKDUvz8jt94yQND0fZhqI9EhVKjcxVqw/gC99z0Cr0LdXhiLXHVV8yU8Ugn/uFt4p/JBaqXPg6zGrvMX1WnN7pSpBnmQouM7CEHCCuHICPjT2dBaY4JCJ/IcsjwY0vL5aPI1vYHYnGmugAsICHpWv0d5RXofV+Tj5T2QsI/T4bvfPXRzLzKknYFFLezZiz98TLOWP5XAf6QdUINxd4+ZjetfIuY87v1VEwZNMZUbuGkWFF3bCfBttS+MWKV8xZUfIjE2vGJYZF+OgOV7tQ49Sn0IIDGysTiWA1DansjnJ7sSKlTWjeSKSXXl5aUIyD7AeZjvqsKqQNlOem6Ti46L8cnKb764gKoJFm1LVmCNet3JZV0Nx7vLgxr4vsAetIdpWZr8g4000wqjWXp+FhceRoAfeKhKCnoE3wCS5iuSRs2uPtcAbrS2nqJQirBtxtGubY2b X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KQwAXET4QbB98HTF011COugLH5YwxvpLuA2adOYaoxNa3jvorg6zMlQEZXxr?= =?us-ascii?Q?4dSJgvgA4b0ZO71hXwCGC/73sDNS629I9xG38iiyj6KfaDwf++dLR2JA9+dm?= =?us-ascii?Q?QByMnSCUnU+/R7MPQpQMuLvWSKWPOy/x/PxSVCHZj3/bfG3OV+Xnre5omdXF?= =?us-ascii?Q?mRCt4Eo6QtllxFXgCTUTIQuTk91dif1443Va1zLGNZ/igWUPBLECkrR1vrfM?= =?us-ascii?Q?2KdVkEuKWN/vsBQfWt/JgH+2BYD+ivQL1IgTgh6yVcftv6ZGwoEQV2IIM5Fw?= =?us-ascii?Q?xbc1X8349aItRUEQmnoVPX7sm+tk8FIksV0cSUqRWEyt++yZ2Pf9mnlq8X1Y?= =?us-ascii?Q?JAyXonllIPkpsWEKJ1IOqcMr/FnFTy1BPFJa6LcDpiIMjnkjIXfJAUyIz0Rl?= =?us-ascii?Q?GFhpDvYI7QtRBhpHDHtRFkAKEIV/4ip/grPdOjVxV890WCQ47Cs8Tdy34ZBM?= =?us-ascii?Q?nGeh1PA2vugs8EoXFZUeJTXBhkiYfHVb6Dfl5TiOP58AOW5tHJe2vVTHF9xv?= =?us-ascii?Q?FJD2DT99+wCAp4oLk9AYLAE6CCh0i9DP7ENZmxp5ZIC7jxGpC4ZSMVU3aV+0?= =?us-ascii?Q?too3QEaqqry8bSoqtUifOWE0wQNS36vHOPAlI6W8/FnCvUyh21GgdpGuhkHi?= =?us-ascii?Q?kw/EXnV6qghgyLODXIQ/wGzhz81Rj7gFHoiirlp1EuClUPzxkCDoS1YZReYk?= =?us-ascii?Q?pWWOdJBa3UMnocQdNzbuwwVqMJsbU0IjmpEPB4w3wmwJoi2Ems6B6tci4E57?= =?us-ascii?Q?s2rFw1+gTgFdEOb8eJHbEjNBUrh0DpmyD8W4nizEPyZ1BbNIpFDwmoBrjtvr?= =?us-ascii?Q?QyoXUC3B477vE/G2cb467Vr5OgTd7JLRxTD9xRgGN5Bm2OxXn3a2vdW9GXcG?= =?us-ascii?Q?CbBOcacWhs2/16vGseDPgMFJ+7xU3J+g2LFNL/sUvX4xVRnoaWBwJLqiMlmW?= =?us-ascii?Q?esponKfTWspEmNbl4FKCclqrkDmFYiHXYId54Lt4EdRpm09ks6IYaE3lfiUh?= =?us-ascii?Q?PXMGgpS9QfBirUpoz/YPMfF6ackcDp2Uuavp8OHaAzwfLPBWCn+YMW/9liq5?= =?us-ascii?Q?q4/nL375wUV9NdGVOUxE5t9LEVDkbN9N67sy5CfxUF1m744SvbVM/Ea6OJRu?= =?us-ascii?Q?cOfyXI4WJsVxa6C2wWh8HnmZ4chwapH4dbWYxVM89Cs3EUhgQ90/EEK3+ubZ?= =?us-ascii?Q?sgiW01ZrDVClBp44I/n0brEfW19EMXY9bTMudYqfceSPdUgJwIYbsOfduq1K?= =?us-ascii?Q?vzzJbqu6HBo52Rdkuds8w9BAAd1qco8eTOiWde5DJg=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-7dc52.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 999bdf05-9bf3-483d-d259-08da7576ceae X-MS-Exchange-CrossTenant-AuthSource: CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2022 17:37:16.4250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CP4P284MB1585 X-Rspamd-Queue-Id: 4LyfFD3LFwz42Ym X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=MqGzRn5x; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (mx1.freebsd.org: domain of tezeka@hotmail.com designates 40.92.97.12 as permitted sender) smtp.mailfrom=tezeka@hotmail.com X-Spamd-Result: default: False [-4.46 / 15.00]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_SHORT(-0.97)[-0.969]; NEURAL_HAM_LONG(-0.97)[-0.967]; NEURAL_HAM_MEDIUM(-0.53)[-0.526]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; R_SPF_ALLOW(-0.20)[+ip4:40.92.0.0/15]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; FREEMAIL_TO(0.00)[hotmail.com]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; RCVD_IN_DNSWL_NONE(0.00)[40.92.97.12:from]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[hotmail.com:+]; FREEMAIL_FROM(0.00)[hotmail.com]; RCPT_COUNT_FIVE(0.00)[5]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_EQ_ADDR_SOME(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 2 Aug 2022, Ivan Quitschal wrote: > > Hi guys > > Currently , if you click 3 times in order to select the entire row, its just > not working as it should. > i fixed that please find below and attached the patches > > With this change now we can do a 3 clicks and paste , i dont know, in some > command, and it will be executed just fine, like it was in syscons, and still > is in xterm/ linux etc > > now if the event is a 3 mouse clickss select, the space trim is made on the > right and an is included > > thanks > > --tzk > > > -------------------- > --- sys/dev/vt/vt_buf.c.orig 2022-08-02 08:44:27.229782000 -0300 > +++ sys/dev/vt/vt_buf.c 2022-08-02 08:45:02.703697000 -0300 > @@ -771,7 +771,7 @@ > } > > void > -vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz) > +vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz, int mark) > { > int i, j, r, c, cs, ce; > term_pos_t s, e; > @@ -799,7 +799,7 @@ > buf[i++] = vb->vb_rows[r][c]; > > /* For all rows, but the last one. */ > - if (r != e.tp_row) { > + if (r != e.tp_row || mark == VTB_MARK_ROW) { > /* Trim trailing word separators, if any. */ > for (; i != j; i--) { > if (!tchar_is_word_separator(buf[i - 1])) > -------------------- > > --- sys/dev/vt/vt_core.c.orig 2022-08-02 08:43:15.436415000 -0300 > +++ sys/dev/vt/vt_core.c 2022-08-02 08:43:49.120096000 -0300 > @@ -2287,7 +2287,7 @@ > VD_PASTEBUFSZ(vd) = len; > } > /* Request copy/paste buffer data, no more than `len' */ > - vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len); > + vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len, > mark); > > VD_PASTEBUFLEN(vd) = len; > > --------------------- > > --- sys/dev/vt/vt.h.orig 2022-08-02 08:41:23.888584000 -0300 > +++ sys/dev/vt/vt.h 2022-08-02 08:41:54.504309000 -0300 > @@ -238,7 +238,7 @@ > #ifndef SC_NO_CUTPASTE > int vtbuf_set_mark(struct vt_buf *vb, int type, int col, int row); > int vtbuf_get_marked_len(struct vt_buf *vb); > -void vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz); > +void vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz, int > mark); > #endif > > #define VTB_MARK_NONE 0 > -------------------------- > hi All this is the solution i found to fix the PASTE MARK issue. today when you select and paste something , the highlight mark stays on screen forever, until you do a mouse 1 button click. this is the way i found to correct that. with this change the highlight mark disappears after you right click to paste. in mouse event, for either case VT_MOUSE_PASTEBUTTON: or case VT_MOUSE_EXTENDBUTTON: i just set "mark" to VTB_MARK_START (i dont use this EXTENDBUTTON feature i didnt find a better way to do that tho, in case any commiter wants to apply that too personally this problem is being bugging me for quite some time now. im sure im not the only one. thanks --tzk PS: below patch includes the previous change on this email chain as well --- sys/dev/vt/vt_core.c.orig 2022-08-02 08:43:15.436415000 -0300 +++ sys/dev/vt/vt_core.c 2022-08-03 12:18:40.216670000 -0300 @@ -2228,23 +2228,28 @@ case 0: /* up */ break; default: + mark = VTB_MARK_START; vt_mouse_paste(); break; } - return; /* Done */ +// return; /* Done */ + case VT_MOUSE_EXTENDBUTTON: switch (cnt) { - case 0: /* up */ + case 0: if (!(vd->vd_mstate & MOUSE_BUTTON1DOWN)) - mark = VTB_MARK_EXTEND; + mark = VTB_MARK_START; +// mark = VTB_MARK_EXTEND; else mark = 0; break; default: - mark = VTB_MARK_EXTEND; +// mark = VTB_MARK_EXTEND; + mark = VTB_MARK_START; break; } break; + default: return; /* Done */ } @@ -2287,7 +2292,7 @@ VD_PASTEBUFSZ(vd) = len; } /* Request copy/paste buffer data, no more than `len' */ - vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len); + vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len, mark); VD_PASTEBUFLEN(vd) = len;