From owner-svn-ports-head@FreeBSD.ORG  Tue Jul 23 16:21:20 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D6391821;
 Tue, 23 Jul 2013 16:21:20 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id AF9C12830;
 Tue, 23 Jul 2013 16:21:20 +0000 (UTC)
Received: from [192.168.0.20] (unknown [130.255.26.7])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 01A5E43B8C;
 Tue, 23 Jul 2013 11:21:10 -0500 (CDT)
Message-ID: <51EEAD6C.7060103@marino.st>
Date: Tue, 23 Jul 2013 18:21:00 +0200
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r323495 - head/games/f1lt
References: <201307221916.r6MJG7Ln085934@svn.freebsd.org>
 <20130723070857.GB10232@FreeBSD.org> <51EEAC10.4000004@FreeBSD.org>
In-Reply-To: <51EEAC10.4000004@FreeBSD.org>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 Jason Helfman <jgh@FreeBSD.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2013 16:21:20 -0000

On 7/23/2013 18:15, Bryan Drewery wrote:
> Quite the contrary. If a change is needed it should be done now, not in
> 2 months or years when it is convenient. Smaller logical commits are
> much simpler to review and bisect than large commits. We should group
> PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*.

"If a change is needed"
The issue is that it is debatable that this change is needed.
It's redundant.
It doesn't hurt anything.
Personally I'm fine with this type of cleanup combined with *needed*
change, but as a standalone commit, I agree with danfe that it doesn't
add much.

Another example of this is trimming makefile headers without any
additional change.

John