Date: Tue, 23 Jul 2013 18:21:00 +0200 From: John Marino <freebsd.contact@marino.st> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Jason Helfman <jgh@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r323495 - head/games/f1lt Message-ID: <51EEAD6C.7060103@marino.st> In-Reply-To: <51EEAC10.4000004@FreeBSD.org> References: <201307221916.r6MJG7Ln085934@svn.freebsd.org> <20130723070857.GB10232@FreeBSD.org> <51EEAC10.4000004@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/23/2013 18:15, Bryan Drewery wrote: > Quite the contrary. If a change is needed it should be done now, not in > 2 months or years when it is convenient. Smaller logical commits are > much simpler to review and bisect than large commits. We should group > PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*. "If a change is needed" The issue is that it is debatable that this change is needed. It's redundant. It doesn't hurt anything. Personally I'm fine with this type of cleanup combined with *needed* change, but as a standalone commit, I agree with danfe that it doesn't add much. Another example of this is trimming makefile headers without any additional change. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51EEAD6C.7060103>