From owner-freebsd-bugs@FreeBSD.ORG  Fri Dec  1 19:50:39 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2F42516A403
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  1 Dec 2006 19:50:39 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2A33843CC2
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  1 Dec 2006 19:50:15 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kB1JoKMx088306
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 1 Dec 2006 19:50:20 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kB1JoKC7088305;
	Fri, 1 Dec 2006 19:50:20 GMT (envelope-from gnats)
Date: Fri, 1 Dec 2006 19:50:20 GMT
Message-Id: <200612011950.kB1JoKC7088305@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: John Baldwin <jhb@freebsd.org>
Cc: 
Subject: Re: kern/103041: [ipmi] unloading ipmi panics Dell PE 2850,
	ipmi doesn't work, 1850 works fine
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Baldwin <jhb@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Dec 2006 19:50:39 -0000

The following reply was made to PR kern/103041; it has been noted by GNATS.

From: John Baldwin <jhb@freebsd.org>
To: Alexander Logvinov <ports@logvinov.com>
Cc: bug-followup@freebsd.org, Paul.Dekkers@surfnet.nl
Subject: Re: kern/103041: [ipmi] unloading ipmi panics Dell PE 2850, ipmi doesn't work, 1850 works fine
Date: Fri, 1 Dec 2006 14:42:49 -0500

 On Sunday 26 November 2006 22:08, Alexander Logvinov wrote:
 > Hello! 
 > 
 > Same problem with FreeBSD 6.2-RC1 and Intel SE7230NH1-E.
 > 
 > # kldload ipmi
 > sio1: configured irq 3 not in bitmap of probed irqs 0
 > sio1: port may not be enabled
 > ipmi0: <IPMI System Interface> port 0x2048-0x204b mem 0x481a0000-0x481a0fff 
 irq 16 at device 0.4 on pci4
 > ipmi0: using KSC interface
 > ipmi0: KCS: Failed to read address
 > ipmi0: KCS: Failed to read address
 > ipmi0: KCS: Failed to read address
 > ipmi0: Failed GET_DEVICE_ID: 5
 
 I've yet to determine why these chips don't work. :(  They seem to just be 
 broken.
 
 Try this patch to fix the kldunload though:
 
 Index: ipmi.c
 ===================================================================
 RCS file: /usr/cvs/src/sys/dev/ipmi/ipmi.c,v
 retrieving revision 1.6
 diff -u -r1.6 ipmi.c
 --- ipmi.c      12 Oct 2006 16:26:42 -0000      1.6
 +++ ipmi.c      1 Dec 2006 19:40:37 -0000
 @@ -888,14 +888,16 @@
         sc->ipmi_cloning = 0;
         IPMI_UNLOCK(sc);
 
 -       EVENTHANDLER_DEREGISTER(dev_clone, sc->ipmi_clone_tag);
 +       if (sc->ipmi_clone_tag)
 +               EVENTHANDLER_DEREGISTER(dev_clone, sc->ipmi_clone_tag);
  #else
         if (sc->ipmi_idev.ipmi_open) {
                 IPMI_UNLOCK(sc);
                 return (EBUSY);
         }
         IPMI_UNLOCK(sc);
 -       destroy_dev(sc->ipmi_idev.ipmi_cdev);
 +       if (sc->ipmi_idev.ipmi_cdev)
 +               destroy_dev(sc->ipmi_idev.ipmi_cdev);
  #endif
 
         /* Detach from watchdog handling and turn off watchdog. */
 
 -- 
 John Baldwin