From nobody Mon Jul 27 13:14:28 2026 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h7zb10KFzz6myST for ; Mon, 27 Jul 2026 13:14:37 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h7zb06pJlz3dpQ for ; Mon, 27 Jul 2026 13:14:36 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785158077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3orRWzYJbp/FmksVbqtS5B/5SqgB3p/nf8pCmvP6to=; b=tiUcKzVo7upuLjGoZO8LIrKWVKFVO7iXAFcdSXphWO0r3Q3URjqT+T8pT9rlAIm53vkN2r 0s74tteDXEgrsRUv/Xs3eGJlKl0XMbdUGMKIYxv9YVE4xR6TFxyOFPvkAodk8teFKKJ4MC d3hOU3GGqMwYiZiqeejZzNEDxHEIiiTrn/p7oZ6160r7ikHzP/sPRQ+xMH1gTn8eIvnX0C 0vH05EjmZCYQehutFa7Z6tF1BNbqBcIfP5t5uuYYRUBJ09YtFTbNwI1bkCNN8o8no8yvLc vNDN+CkoRmfQGYKjbU4igR+nOWne3PEjJ1WWJfkwqZ/YNN3uqaC7ic0K4x+LWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785158077; a=rsa-sha256; cv=none; b=Wt5KtCPZkJJ5B323lC5ObuXDMNti8CFVd2C+rDrBJe1Jt9UKQwYxf1QUi5GOwx5348WA1j P4p8QVCn+PY61QlAeh5fmDggGAbzs9YqlzXxBX9QPj2CAhV0c1WDm1tczueNZ0+FgTaVwF I2hYW7CxawaYeVUPYeOW/9A8acMvGw1WcbFR5a1trXMN07QLZ2d8fN6+2ONK9ywEmdIyRc eFA6C1nSOLtKQpTCBo/61C4ogt0jjNWABoINXLA/OBVS6CxZvruyYWAyYq+v/iGF8Ywkvc LK9bFZSRuGVr29zH/WzLodxWmQemHqX5arqrydyoSG74HDByEiyyBB99FGEnZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785158077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3orRWzYJbp/FmksVbqtS5B/5SqgB3p/nf8pCmvP6to=; b=Cp4JmzjYrYQ953FAJ7oDcpLQUeEdc+8DJ02dI/7vTbOKJmmLdQ7wJEx5Ct+5thDHg9009u RfPcdGzqK9cTsnIhhhl3W2mqHmOA/Iz0K8RzM/2SgXhZotSdcZHorEk+pE6onjBcM24GZJ xfz4QnxJa+iJubpBEw+7ApszCjPlNMs2XhtfFxzvjACAGhmt+I3DCn6yF+cIOGhU1VKW3P IH23KIsrmNzMPLr1+9slw2Wd7T6TsP5T4bBZ09w0P6aRt4VOGj57SRBq66vsNNEaTa7prk HQFFhutbR/uo+50QadbDOorzR5JO3a4PtOkmjussuHM0lK/i6B77c4pxu4JRjw== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "YE2" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4h7zb04LcDznWC for ; Mon, 27 Jul 2026 13:14:36 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 0E282A64805 for ; Mon, 27 Jul 2026 13:13:59 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 382422D029E9 for ; Mon, 27 Jul 2026 13:14:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id QqEdYXY-3SPP for ; Mon, 27 Jul 2026 13:14:28 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 6D7AD2D029D8 for ; Mon, 27 Jul 2026 13:14:28 +0000 (UTC) Date: Mon, 27 Jul 2026 13:14:28 +0000 (UTC) From: "Bjoern A. Zeeb" To: freebsd-current Subject: Re: amd64 boot crash for lack of being set up to use of rtw89; linuxkpi calls on the stack, 0xdeadc0dedeadc13e and such involved, devfs_ioctl with dsw=0xdeadc0dedeadc0de In-Reply-To: <531q4s72-168s-672r-1817-3985905s96o@SerrOFQ.bet> Message-ID: References: <62ded8a9-a1ce-42e8-836b-53b4de21d333.ref@yahoo.com> <62ded8a9-a1ce-42e8-836b-53b4de21d333@yahoo.com> <531q4s72-168s-672r-1817-3985905s96o@SerrOFQ.bet> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Sat, 25 Jul 2026, Bjoern A. Zeeb wrote: > Can you test this? > > % git diff > diff --git sys/compat/linuxkpi/common/src/linux_pci.c > sys/compat/linuxkpi/common/src/linux_pci.c > index a49254425b5d..b1c28a188b94 100644 > --- sys/compat/linuxkpi/common/src/linux_pci.c > +++ sys/compat/linuxkpi/common/src/linux_pci.c > @@ -370,7 +370,7 @@ lkpi_pci_dev_release(struct device *dev) > */ > > /* Clear the hierarchy recursively to root. */ > - if (pdev->bus->self != pdev) { > + if (pdev->bus->self != pdev && pdev->bus->self != NULL) { > pci_dev_put(pdev->bus->self); > pdev->bus->self = NULL; > } Just for the archives: ths above change is a NOP as pci_dev_put() does check for the passed in pdev to be != NULL; so contrary to what I have said in the thread I'll not commit this. /bz -- Bjoern A. Zeeb r15:7