From owner-dev-commits-src-all@freebsd.org  Wed Jan 27 23:08:31 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8EC424EC7DD;
 Wed, 27 Jan 2021 23:08:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DQzmb3QL5z3l9b;
 Wed, 27 Jan 2021 23:08:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (unknown
 [IPv6:2601:648:8681:1cb0:30aa:99ed:637e:111e])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id E6F4B29CD1;
 Wed, 27 Jan 2021 23:08:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: 6e26189be406 - main - Fix loader detection of vbefb support
 on !amd64
To: Dimitry Andric <dim@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202101272129.10RLTAee080408@gitrepo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <3973a397-1250-1230-fecc-956b84c74fc9@FreeBSD.org>
Date: Wed, 27 Jan 2021 15:08:28 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <202101272129.10RLTAee080408@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2021 23:08:31 -0000

On 1/27/21 1:29 PM, Dimitry Andric wrote:
> The branch main has been updated by dim:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=6e26189be406a9a3799074b16925e6cd63cc703b
> 
> commit 6e26189be406a9a3799074b16925e6cd63cc703b
> Author:     Dimitry Andric <dim@FreeBSD.org>
> AuthorDate: 2021-01-27 21:28:43 +0000
> Commit:     Dimitry Andric <dim@FreeBSD.org>
> CommitDate: 2021-01-27 21:28:43 +0000
> 
>      Fix loader detection of vbefb support on !amd64
>      
>      On i386, after 6c7a932d0b8baaaee16eca0ba061bfa6e0e57bfd, the vbefb vt
>      driver was no longer detected by the loader, if any kernel module was
>      loaded after the kernel itself.
>      
>      This was caused by the parse_vt_drv_set() function being called multiple
>      times, resetting the detection flag. (It was called multiple times,
>      becuase i386 .ko files are shared objects like the kernel proper, while
>      this is not the case on amd64.)
>      
>      Fix this by skipping the set_vt_drv_set lookup if vbefb was already
>      detected.
>      
>      Reviewed by:    tsoome

Does the state get reset if you unload one kernel and then load a different
one (e.g. via interactive 'unload' and 'load /path/to/my/kernel')?

-- 
John Baldwin