From owner-freebsd-current@FreeBSD.ORG Tue Mar 17 21:08:26 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 93523507; Tue, 17 Mar 2015 21:08:26 +0000 (UTC) Received: from relay.mailchannels.net (si-002-i77.relay.mailchannels.net [184.154.112.252]) by mx1.freebsd.org (Postfix) with ESMTP id 63912C37; Tue, 17 Mar 2015 21:08:23 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp7.ore.mailhop.org (ip-10-229-11-165.us-west-2.compute.internal [10.229.11.165]) by relay.mailchannels.net (Postfix) with ESMTPA id D5D8F120855; Tue, 17 Mar 2015 21:08:17 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp7.ore.mailhop.org (smtp7.ore.mailhop.org [10.21.145.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Tue, 17 Mar 2015 21:08:20 +0000 X-MC-Relay: Bad X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1426626499997:672116081 X-MC-Ingress-Time: 1426626499996 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp7.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YXyik-00018m-8E; Tue, 17 Mar 2015 21:08:14 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t2HL8773026353; Tue, 17 Mar 2015 15:08:07 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+J/qkcCBGxguBJ264WcUez Message-ID: <1426626487.62241.15.camel@freebsd.org> Subject: Re: sbuf-related panic From: Ian Lepore To: Craig Rodrigues Date: Tue, 17 Mar 2015 15:08:07 -0600 In-Reply-To: References: <1426529019.4766.1.camel@hardenedbsd.org> <1426618197.670703.241661961.0D1A6F14@webmail.messagingengine.com> <1426618644.62241.4.camel@freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie Cc: freebsd-current Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 21:08:26 -0000 On Tue, 2015-03-17 at 12:14 -0700, Craig Rodrigues wrote: > On Tue, Mar 17, 2015 at 11:57 AM, Ian Lepore wrote: > > > > > There is still a panic, one that I can't yet figure out why it wasn't > > panicking before my changes, but I'm working on it. > > > > > Can you run the kyua tests on your system? > > > https://wiki.freebsd.org/201411DevAndVendorSummit?action=AttachFile&do=view&target=kyua_jenkins.pdf > > Those tests seem to be reproducibly triggering the problem. > Triggering it wasn't the problem, understanding why it didn't used to fail and now it does was the tricky bit. :) It turns out it never failed before because nobody had tried to use default allocations (pointer and size zero) with sbuf_new_for_sysctl() before, and it didn't fail for me while I was testing my changes because I had commented-out INVARIANTS in my kernel config and forgotten that (doh!) so none of the assertions were actually being tested. So I fixed my test environment, then I fixed the code. Hopefully it's all better now. -- Ian