From owner-svn-ports-head@FreeBSD.ORG  Mon Jan 13 15:50:11 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 19BFC55E;
 Mon, 13 Jan 2014 15:50:11 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 05D311AC8;
 Mon, 13 Jan 2014 15:50:11 +0000 (UTC)
Received: from nemysis4now (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with SMTP id s0DFo8nq062959;
 Mon, 13 Jan 2014 15:50:08 GMT (envelope-from nemysis@FreeBSD.org)
Received: by nemysis4now (sSMTP sendmail emulation);
 Mon, 13 Jan 2014 16:50:07 +0100
Date: Mon, 13 Jan 2014 16:50:07 +0100
From: Rusmir Dusko <nemysis@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r338474 - head/net-p2p/libtorrent-rasterbar
Message-ID: <20140113155007.GA13066@nemysis4now>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 15:50:11 -0000

> On Thu, Jan 02, 2014 at 07:47:58PM +0000, Rusmir Dusko wrote:
> > New Revision: 338474
> > URL: http://svnweb.freebsd.org/changeset/ports/338474
> > 
> > Log:
> >   - Bump PORTREVISION
> >   - Fix build on 8.x and 9.x
> >   - Use USES=compiler:c++11-lang instead of compiler  

> Can you elaborate a bit on the necessity of USES=compiler:c++11-lang here?
> I didn't notice any C++11 features used in the source code; at least base
> GCC builds it just fine.  There is a problem with ./configure script: it
> passes -ftemplate-depth=120 option during Boost detection; but that can be
> easily remedied with simple sed(1) script.  Would you consider attached
> patch?

Thanks i will elaborate your patch.


This is good

-CONFIGURE_ARGS+=       --disable-debug \
+CONFIGURE_ARGS=        --disable-debug \


I don't approve this, because it is needed for successful build on PointyHat

-USES=          compiler:c++11-lang pathfix pkgconfig iconv
+USES=          pathfix pkgconfig icon


This is unnecessary, Clang and GCC have this Option:

http://clang.llvm.org/docs/genindex.html

http://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html

+       @${REINPLACE_CMD} -e '/-ftemplate-depth/d' ${WRKSRC}/configure


This is good break lines around 80 characters, i use this for all Ports

-       ${INSTALL_DATA} ${PORTEXAMPLES:S|^|${WRKSRC}/examples/|} ${STAGEDIR}${EXAMPLESDIR}
+       ${INSTALL_DATA} ${PORTEXAMPLES:S|^|${WRKSRC}/examples/|} \
+               ${STAGEDIR}${EXAMPLESDIR}


Build log on RedPorts is not relevant, important is from PointyHat

https://redports.org/buildarchive/20140113145200-49735/


This build on RedPorts was good but failed on PointyHat,
I think this is too with your diff

https://redports.org/buildarchive/20140102183201-55841/


-- 
Best regards,
Rusmir Dusko