From owner-cvs-all Mon May 25 05:03:40 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA04778 for cvs-all-outgoing; Mon, 25 May 1998 05:03:40 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA04737; Mon, 25 May 1998 05:03:31 -0700 (PDT) (envelope-from dag-erli@ifi.uio.no) Received: from ringhorni.ifi.uio.no (2602@ringhorni.ifi.uio.no [129.240.64.75]) by ifi.uio.no (8.8.8/8.8.7/ifi0.2) with ESMTP id OAA13895; Mon, 25 May 1998 14:03:27 +0200 (MET DST) Received: (from dag-erli@localhost) by ringhorni.ifi.uio.no ; Mon, 25 May 1998 14:03:26 +0200 (MET DST) Mime-Version: 1.0 To: Steve Price Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/who who.c References: <199805250719.AAA00290@freefall.freebsd.org> Organization: University of Oslo, Department of Informatics X-url: http://www.stud.ifi.uio.no/~dag-erli/ X-Stop-Spam: http://www.cauce.org From: dag-erli@ifi.uio.no (Dag-Erling Coidan =?iso-8859-1?Q?Sm=F8rgrav?= ) Date: 25 May 1998 14:03:24 +0200 In-Reply-To: Steve Price's message of "Mon, 25 May 1998 00:19:08 -0700 (PDT)" Message-ID: Lines: 43 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Steve Price writes: > Modified files: > usr.bin/who who.c > Log: > Only allow 'who' and 'who am i' as valid usages. Umm, didn't I fix this an eternity ago? revision 1.6 date: 1998/04/26 19:10:51; author: des; state: Exp; lines: +5 -1 Check that user really typed "who am {I,i}", and that no stray arguments are given. Note that usage() and the manpage disagree... PR: bin/6294 Suggested by: Ruslan Ermilov and Bruce Evans Submitted by: Ruslan Ermilov (partly) Your diff does nothing: Index: who.c =================================================================== RCS file: /home/ncvs/src/usr.bin/who/who.c,v retrieving revision 1.6 retrieving revision 1.7 diff -r1.6 -r1.7 48c48 < "$Id: who.c,v 1.6 1998/04/26 19:10:51 des Exp $"; --- > "$Id: who.c,v 1.7 1998/05/25 07:19:07 steve Exp $"; 56a57 > #include 74a76,78 > > if (getopt(argc, argv, "") != -1) > usage(); the getopt() check is unnecessary because the if (strcmp(...)) further down will catch it. The #include is unnecessary because it is only needed for getopt(). -- Noone else has a .sig like this one. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message