From owner-cvs-src Thu Feb 20 15:21:26 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7F3237B405 for ; Thu, 20 Feb 2003 15:21:24 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id BE33843FCB for ; Thu, 20 Feb 2003 15:21:20 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 52023 invoked by uid 1000); 20 Feb 2003 23:21:19 -0000 Date: Thu, 20 Feb 2003 15:21:19 -0800 (PST) From: Nate Lawson To: Maxime Henrion Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c In-Reply-To: <20030220212005.GP60813@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 20 Feb 2003, Maxime Henrion wrote: > Nate Lawson wrote: > > On Wed, 19 Feb 2003, Maxime Henrion wrote: > > > Modified files: > > > sys/pci if_xl.c > > > Log: > > > Fix panic on sparc64 introduced in my last commit. I really > > > wish the busdma APIs were more consistent accross architectures. > > > > > > We should probably move all the other DMA map creations in > > > xl_attach() where we can really handle them failing, since > > > xl_init() is void and shouldn't fail. > > > > Please see my patches for adding/fixing error handling for dmamap_load > > (posted to -current). I am going to remove the unnecessary intr alloc > > move but otherwise they should be fine. > > Where are those patches ? I only found > http://www.root.org/~nate/freebsd/xl.diff, which is not related to > busdma at all. You're right. The fixes were for other drivers. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message