Date: Thu, 10 Nov 2011 09:30:14 GMT From: vwe@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/162426: mail/postgrey bad postgrey_options default in rc.d file Message-ID: <201111100930.pAA9UEsK088926@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/162426; it has been noted by GNATS. From: vwe@freebsd.org To: Darren Pilgrim <ports.maintainer@evilphi.com> Cc: bug-followup@FreeBSD.org Subject: Re: ports/162426: mail/postgrey bad postgrey_options default in rc.d file Date: Thu, 10 Nov 2011 10:18:13 +0100 On 11/10/11 09:18, Darren Pilgrim wrote: > Yes, I'm aware, thanks. The commit that introduced the error has been > reverted. This PR can be closed. Dear Darren, I'm sorry to tell but I resist to close this PR as according to cvsweb (yes, I know cvsweb isn't authoritative) files/postgrey.in is still at rev 1.6, last modified at 2011-11-09, and hasn't been fixed yet. I can see, there has been a commit changing some of your ports' files some hours back, but the issue is still there. I was able to confirm cvsweb output by doing a fresh checkout of the ports tree. On a personal note, I do not recommend to roll back a bigger commit just to fix a minor problem. If a commit introduces a new problem, fixing just the new problem would be an appropriate action IMHO. YMMV but everything else makes the commit log harder to read and understand. Regards, Volker Werth
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201111100930.pAA9UEsK088926>