Date: Wed, 20 Nov 2013 13:31:19 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Grzegorz Bernacki <gber@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r258387 - head/sys/dev/nand Message-ID: <20131120213119.GL2279@funkthat.com> In-Reply-To: <201311201110.rAKBAOMY061212@svn.freebsd.org> References: <201311201110.rAKBAOMY061212@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Grzegorz Bernacki wrote this message on Wed, Nov 20, 2013 at 11:10 +0000: > Author: gber > Date: Wed Nov 20 11:10:23 2013 > New Revision: 258387 > URL: http://svnweb.freebsd.org/changeset/base/258387 > > Log: > Split raw reading/programming into smaller chunks to avoid allocating too > big chunk of kernel memory. Validate size of data. Add error handling to > avoid calling copyout() when data has not been read correctly. > > Reviewed by: zbb > Reported by: x90c <geinblues@gmail.com> > MFC after: 2 days > > Modified: > head/sys/dev/nand/nand_cdev.c > head/sys/dev/nand/nand_geom.c Looks like this change errors w/ gcc: http://tinderbox.freebsd.org/tinderbox-head-noclang-build-HEAD-armv6-arm.brief -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131120213119.GL2279>