From owner-freebsd-current@FreeBSD.ORG Fri Jul 15 21:36:41 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4352D16A41C; Fri, 15 Jul 2005 21:36:41 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6C1B43D48; Fri, 15 Jul 2005 21:36:40 +0000 (GMT) (envelope-from nate@root.org) Received: from [192.168.52.136] (ip-207-145-88-3.nyc.megapath.net [207.145.88.3]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j6FLado5026018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 15 Jul 2005 14:36:39 -0700 Message-ID: <42D82A7F.4050208@root.org> Date: Fri, 15 Jul 2005 14:28:31 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <4.3.2.7.2.20050711121036.02caa348@mail.qconline.com> <200507111626.25124.jhb@FreeBSD.org> <42D2F177.3070101@root.org> <200507121027.14113.jhb@FreeBSD.org> In-Reply-To: <200507121027.14113.jhb@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, Harry Coin Subject: Re: mss.c pcm fix to ' attach returned 6 ' load failure for v5.x acpi and up X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2005 21:36:41 -0000 John Baldwin wrote: > On Monday 11 July 2005 06:23 pm, Nate Lawson wrote: > >>John Baldwin wrote: >> >>>Also, can you upload your acpidump somewhere and provide a URL? I'm >>>curious if you have ACPI devices like thermal zones that don't have >>>_HID's and only have _CIDs. In fact, here's a patch to fix >>>acpi_get_logicalid() in that case. Give this a try first and let me know >>>if it fixes it. >> >>I would rather you directly call acpi_isa_get_compatid() rather than >>duplicating its logic here. There's no guarantee that the first CID >>will match the single ID passed in. > > > There is no passed in ID. For the common use of this function in almost all > ISA drivers, it just needs to return != 0 for PNP devices. I really think the driver is broken and the API is fine for this. I don't like the hack of returning a random CID for checks against the HID. Drivers down the road may come to rely on this and then every BIOS that has a different order for CIDs becomes a potential breakage point. Drivers should not rely on isa_get_logicalid() to determine a boolean "is PNP?" -- Nate