Date: Sun, 17 Jan 2021 19:49:32 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 252787] fstyp heuristics can misidentify UFS file systems created by newfs, goofs up autofs's special_media map Message-ID: <bug-252787-227-7k7mdrHP6B@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-252787-227@https.bugs.freebsd.org/bugzilla/> References: <bug-252787-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252787 --- Comment #1 from Conrad Meyer <cem@freebsd.org> --- In 13 (r355996), fstyp can locate exFAT labels and probably avoid a false positive match with UFS most of the time. (Specifically, we look at the fi= rst 11 sectors now and verify them against a checksum in sector 12.) (Unfortunately, some (all?) of the 'goto done's in fstyp_exfat() should be changed to 'goto fail'. Until that is done, 13's fstyp is no better than 1= 2's as far as just looking for the magic "EXFAT" string.) newfs probably avoids writing the first sector for historical reasons (don't want to clobber a boot sector) which probably means there is an inherent collision between reimaged classic FAT / UFS volumes. Maybe fstyp could be smarter here (some tie-breaking scheme for multiple positive results) if it= is straightforward to be "really sure" a volume is UFS and not FAT. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252787-227-7k7mdrHP6B>