From owner-freebsd-ppc@freebsd.org Sun Jan 12 01:28:33 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 83BC91FB989 for ; Sun, 12 Jan 2020 01:28:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic309-22.consmr.mail.gq1.yahoo.com (sonic309-22.consmr.mail.gq1.yahoo.com [98.137.65.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47wJyR58bZz3FsC for ; Sun, 12 Jan 2020 01:28:30 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: IwqJZpQVM1m28Jn1V69Fw_OiE2zRLTrDcbF7Bw69kqfDLXl1fwCkCJJWkhba_iE Cx8Go0uSuX8Kg1ecR79.9XsBjIh8mpOvRG8O_Z0vbSVFboBqnbwDNjN2a3T15gHzuPmxiR.YDsJt UmdoahqtuTbRrh5UsEILwrR.rp01QYMOLwhzjdjT3xPXHZ5JP3RO88srOi4Pg85y7QwgjGXafJQ5 e1jLAnETfOO0adOe1ung8T0xOvlsBReVvl185.QTY9K1V_yzHfaeD6vxSyeMoOayegJq.Mqpcuzl hBBHV9uqeX5XW9Hn7vxeeWGp99qUD88CjJzpZrAl_7XWhswUouFrC3jI9HPecjO4ZKZyjAqTzwix .VsX.m6QkZ9yQM3i5owFaDoUlRxmSqYTQAa6kDrNcApxNZGQkaALwsbwuydRRyc43mznX4t4.Sx6 zt6T_jXYzTL71S657Zb9LaKfrPusC266NCL37i3athnI93q3zQGCNseRNDQOdYiXL9D.sDYNe4VW UT.LMLfsBdLGrZs2H4FOK1kev2X.ZHF0iynLqkwJJHln7EzIwjZxX1fJZ2gFNkYJSXlo3fd4TU.C 6w_sNtuJFXE8G0NSWKKkmhmX_SCtVg1Ez8lwtgYTnyfLeB85JBqYfsm4RzPgItqG0yblqTKEemAP 8wCxthL_ejQR7r0YUCZEX.AEAIBqzzsq2VVXEE3DsV_9_ATHXxgz0.NWEmWcT3MJeLzkhmOvW34g VERU2SZ.EVhU3Y48fCh8dgtb.33wCEShd9Ppqvala8sIg6D9oEelzf1s.hO3OLJQvy4UErqDUxvu xUsIfDvGFfqrI6HvAE09Ym0iNEdkkQK9c.J0KmeHSbtyRKP3vuBicE7H32zRfVY.fdK_WBdQthSU AMoaEAI4virLVmS60jF2Q9nyj9Xq26bqCh9byB9UfqHcJi3CihXevPhqMl5pjRcuQ8y88GVDoqC9 HpeHvc52Sw9FSJRG6CrddfwkQoaPv0xOwKP7LCsskKrYQn.XwdDf886LSD9fAw15NaDl5MtT9Zyx T37ROsINj3y5W6Ahr1u6UDDgRrY4puIbrOl2vr8vnaqqBMxQJykoLjajSL.Wqz7vTiabbHwVGwjc s3yXMrHxmcpsK0CvE3Bxfu217ATrUSR0ZKbyLSWzYr8UOgTWmA5sejSkF5gMwJisHSfCyFwbvO9N UkVkW.0VuvA.eTuPqsmzE7iBCafOwT80mF8fuLkkhJMnq2dFd7ZHKqMfv0zwOXA8jdyxrK.KJTys 6G7ft69aR151uv0cuvxw9GDSKVx2P7KmbpN3WV_YDhXJtKbw96YbSU4f7b9mm9JQEVPq1iuwAQ7l gWQDj9UcrQQ6XU9tPBuO7HJHIOoW7fPtMF2rX.R7wvQJsSaos3qclYo5ZlsTog9frtUG98m6XKF7 1KTVNKa2KDXV4mijdiNmxRYPASalKxj2xOg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Jan 2020 01:28:27 +0000 Received: by smtp413.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID eea3b152dcb1648b16beb46311e82e01; Sun, 12 Jan 2020 01:28:23 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: head -r356640 and mixed signed/unsigned comparisons Message-Id: <18622739-BB2E-432B-B877-2FBE3A9D4ECB@yahoo.com> Date: Sat, 11 Jan 2020 17:28:22 -0800 To: Justin Hibbits , FreeBSD PowerPC ML X-Mailer: Apple Mail (2.3608.40.2.2.4) References: <18622739-BB2E-432B-B877-2FBE3A9D4ECB.ref@yahoo.com> X-Rspamd-Queue-Id: 47wJyR58bZz3FsC X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.50 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MV_CASE(0.50)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-1.51), ipnet: 98.137.64.0/21(0.87), asn: 36647(0.70), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[148.65.137.98.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jan 2020 01:28:33 -0000 The code: 394 for (j =3D 0; j < addr_cells - 1; j++) { looks wrong to me. Evidence follows. /usr/src/sys/dev/ofw/openfirm.h:typedef uint32_t pcell_t; /usr/include/sys/_stdint.h:typedef __uint32_t = uint32_t; /usr/include/machine/_types.h:typedef unsigned int = __uint32_t; So pcell_t and int are of the same rank but different unsigned vs. signed status. =46rom sys/powerpc/mpc85xx/lbc.c : 363 static int 364 fdt_lbc_reg_decode(phandle_t node, struct lbc_softc *sc, 365 struct lbc_devinfo *di) 366 { . . . 369 pcell_t addr_cells, size_cells; . . . 371 int i, j, rv, bank; . . . 394 for (j =3D 0; j < addr_cells - 1; j++) { 395 start <<=3D 32; 396 start |=3D reg[j]; 397 } So, for line 394, after the usual arithmetic conversions for the "-" and then for the "<" the line would look like (consolidating some relevant material to be more textually-local for ease of comparison): for (int j =3D 0; (unsigned int)j < addr_cells-1u; j++) For addr_cells=3D=3D0u: addr_cells-1u =3D=3D UINT_MAX . So, for addr_cells=3D=3D0u substituted (at run-time): for (int j =3D 0; (unsigned int)j < UINT_MAX; j++) So, unless it is guaranteed that 0u