From owner-svn-src-head@FreeBSD.ORG Thu Jun 11 04:37:49 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 844ACD10; Thu, 11 Jun 2015 04:37:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EBD7910E5; Thu, 11 Jun 2015 04:37:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t5B4bhGu074134 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 11 Jun 2015 07:37:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t5B4bhGu074134 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t5B4bhte074133; Thu, 11 Jun 2015 07:37:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 11 Jun 2015 07:37:43 +0300 From: Konstantin Belousov To: Dimitry Andric Cc: Bruce Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284167 - head/sys/i386/i386 Message-ID: <20150611043743.GZ2499@kib.kiev.ua> References: <201506082012.t58KCjZX023061@svn.freebsd.org> <20150609162836.C935@besplex.bde.org> <14AE3E08-5D5D-437F-A2D3-C89A8CF4B0C1@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14AE3E08-5D5D-437F-A2D3-C89A8CF4B0C1@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2015 04:37:49 -0000 On Tue, Jun 09, 2015 at 08:05:55PM +0200, Dimitry Andric wrote: > On 09 Jun 2015, at 08:44, Bruce Evans wrote: > > > > On Mon, 8 Jun 2015, Dimitry Andric wrote: > > > >> Log: > >> Merge r283870 from amd64: > >> > >> Remove unneeded NULL checks in trap_fatal(). > >> > >> Since td_name is an array member of struct thread, it can never be NULL, > >> so the check can be removed. In addition, curproc can never be NULL, > >> so remove the if statement, and splice the two printfs() together. > >> > >> While here, remove the u_long cast, and use the correct printf format > >> specifier for curproc->p_pid. > >> > >> Requested by: jhb > > > > Er. I gave a longer review which implicity requested not doing all of > > this. The format was correct (it matched the cast), and the cast was > > less wrong than not casting. > > Please read https://reviews.freebsd.org/D2695, where Kostik argued > "pid_t is int32_t on all arches", and I agreed with that. The previous > obfuscation is unnecessary now. > > > > Both amd64/trap.c i386/trap.c still print pids portably (by casting > > to long) in one place. They each had 2 unportable printings of pids; > > now they each have 3 unportable printings of pids. Please note that arguing about portability of the {i386,amd64}/trap.c is not very useful due to the nature of the code. > > I wasn't updating the other parts of the code, so I stayed out of there > for now. Feel free to put a review in Phabricator to make everything > consistent. > > -Dimitry >