From owner-cvs-all Thu Dec 19 1:58:59 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 037DE37B401; Thu, 19 Dec 2002 01:58:58 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C17A43EC2; Thu, 19 Dec 2002 01:58:56 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA22564; Thu, 19 Dec 2002 20:58:54 +1100 Date: Thu, 19 Dec 2002 21:00:05 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Johan Karlsson Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/bin/realpath realpath.c In-Reply-To: <20021219081755.GA35556@numeri.campus.luth.se> Message-ID: <20021219205223.D30429-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 19 Dec 2002, Johan Karlsson wrote: > On Thu, Dec 19, 2002 at 12:01 (+1100) +0000, Bruce Evans wrote: > > On Wed, 18 Dec 2002, Johan Karlsson wrote: > > > - use MAXPATHLEN per realpath(3) > > > > This is sort of backwards. realpath(3) is standard in POSIX.1.2001 and > > spells the limit {PATH_MAX}. MAXPATHLEN has the advantage of being > My commit made the code consistent with the manpage for realpath(3) which > says to use MAXPATHLEN. If that is wrong then we should change > the manpage to say PATH_MAX. > > Should I revert this and change the manpage? Up to you. Lots of things should be changed to say something like {PATH_MAX} (not PATH_MAX) eventually. {PATH_MAX} is POSIX's markup for the the value that is PATH_MAX if PATH_MAX is defined and pathconf(mumble) in general. Most man pages don't even use MAXPATHLEN yet. They hard-code MAXPATHLEN - 1 as 1023. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message