Date: Thu, 12 Jan 2012 22:37:24 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Mark Linimon <linimon@lonesome.com> Cc: Michael Scheidell <scheidell@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Greg Larkin <glarkin@FreeBSD.org>, Gabor Kovesdan <gabor@FreeBSD.org>, raven428@gmail.com, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc Message-ID: <4F0FD124.6000303@FreeBSD.org> In-Reply-To: <20120113042839.GB12998@lonesome.com> References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org> <4F0ED9F1.20305@FreeBSD.org> <4F0F800E.6060505@FreeBSD.org> <20120113042839.GB12998@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/12/2012 20:28, Mark Linimon wrote:
> On Thu, Jan 12, 2012 at 04:51:26PM -0800, Doug Barton wrote:
>> On 01/12/2012 05:02, Gabor Kovesdan wrote:
>>> Em 11-01-2012 00:08, Doug Barton escreveu:
>>>> .if ${MYSQL_VER} == 52
>>>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mariadb-server
>>>> .else
>>>> MYSQL_PORTDIR= ${PORTSDIR}/databases/mysql${MYSQL_VER}-server
>>>> .endif
>>> Although compatible, MariaDB is not MySQL.
>>
>> We use it heavily as a drop-in replacement and have not run into any
>> problems. Do you have specific concerns?
>
> To me, on inspection it would be surprising behavior.
>
> I requested MySQL and I got something else as a dependency instead.
Well you snipped the part of my previous post that answers this, so let
me try again.
MYSQL_VER is a user knob. It's defined in bsd.databases.mk. If a user
sets MYSQL_VER= 52 it means that they are choosing, on purpose, to use
mariadab as their version of mysql. So, "I requested MySQL and I got
something else as a dependency instead" isn't happening. If you need to
know more about mariadb feel free to visit http://mariadb.org/.
Further, every other port that uses mysql as a dependency already works
the way I described. The bug in this port is that it doesn't properly
honor the user's MYSQL_VER setting. That bug needs to be fixed, that's all.
Doug
--
You can observe a lot just by watching. -- Yogi Berra
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0FD124.6000303>