From nobody Mon Jan 5 11:50:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dlCKf0bcsz6MNJL; Mon, 05 Jan 2026 11:50:30 +0000 (UTC) (envelope-from fuz@fuz.su) Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "fuz.su", Issuer "fuz.su" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dlCKd421tz3HVH; Mon, 05 Jan 2026 11:50:29 +0000 (UTC) (envelope-from fuz@fuz.su) Authentication-Results: mx1.freebsd.org; none Received: from fuz.su (localhost [127.0.0.1]) by fuz.su (8.18.1/8.18.1) with ESMTPS id 605BoKh9018449 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 5 Jan 2026 12:50:20 +0100 (CET) (envelope-from fuz@fuz.su) Received: (from fuz@localhost) by fuz.su (8.18.1/8.18.1/Submit) id 605BoJGd018448; Mon, 5 Jan 2026 12:50:19 +0100 (CET) (envelope-from fuz) Date: Mon, 5 Jan 2026 12:50:19 +0100 From: Robert Clausecker To: Konstantin Belousov Cc: Robert Clausecker , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 9c68745a5064 - stable/15 - libc/amd64: fix stpncpy.S again Message-ID: References: <695a69f1.39da1.5b9f90d9@gitrepo.freebsd.org> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dlCKd421tz3HVH Hi Konstantin, Am Mon, Jan 05, 2026 at 03:31:08AM +0200 schrieb Konstantin Belousov: > On Sun, Jan 04, 2026 at 01:24:01PM +0000, Robert Clausecker wrote: > > The branch stable/15 has been updated by fuz: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=9c68745a50640ccff37565e3cbfe53dddc18d7d3 > > > > commit 9c68745a50640ccff37565e3cbfe53dddc18d7d3 > > Author: Robert Clausecker > > AuthorDate: 2025-12-18 23:37:33 +0000 > > Commit: Robert Clausecker > > CommitDate: 2026-01-04 13:22:51 +0000 > > > > libc/amd64: fix stpncpy.S again > > > > The previous fix introduced a regression on machines without the BMI1 > > instruction set extension. The TZCNT instruction used in this function > > behaves different on old machines when the source operand is zero, but > > the code was originally designed to never trigger this case. The bug > > fix caused this case to be possible, leading to a regression on > > sufficiently old hardware. > > > > Fix the code by messing with things such that the source operand is > > never zero. > > > > PR: 291720 > > Fixes: 66eb78377bf109af1d9e25626bf254b4369436ec > > Tested by: cy > > Approved by: markj (mentor) > > Differential Revision: https://reviews.freebsd.org/D54303 > > > > (cherry picked from commit 2f83319214d9adb8ab7a77e35d1014658b3f9cae) > > Why do you perform insta-MFC? Even for bug fixes, the strict policy is to > have at least 3 days probation for the change in HEAD. Thank you for the reminder. Cy noted that he had tested the change for several weeks and it was fine. I will stick to the policy more strictly in the future. Yours, Robert Clausecker -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachments