From owner-cvs-ports@FreeBSD.ORG Fri Jun 17 04:19:56 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58D2F106564A; Fri, 17 Jun 2011 04:19:56 +0000 (UTC) (envelope-from wenheping@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id A3AFF8FC1A; Fri, 17 Jun 2011 04:19:55 +0000 (UTC) Received: by qwc9 with SMTP id 9so1403848qwc.13 for ; Thu, 16 Jun 2011 21:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=n+ONszrh0JvHRxej7OJ2Ij8h7FMdgrIZCDH0pfmf2jw=; b=kT5kl6eTqH4lpTAzoX1Pd2JjRNxy+Gf90o3uVBpd942FRmTofDM8b0KoeIM4kGpnvR 6/mkWkhhdwOgOxt/PJ469CB9E2+y8zX2KbSq6mBVKOer9ahhsmka08Wf1PLvOb+g7lNn sn3ZRUkGLl+i7ukJ1ghHKbvP6OadVKqhlTG+o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=m23Plj2yCoRyMhM9PTxA6Kc4DGVnqqlL+BP8yL2afo0IL3OGEE73oXb9SdJc8gmDxl gpUxCdPhPhOdVj8GXbyDlqDSMMmFB2fu3MnhsSwts+fUIudKRRS60ahg7Ydj8eylaCHh 2c/50Ti56YqcsR37H9YIcfGeU9Mcb17+q+hIY= MIME-Version: 1.0 Received: by 10.224.183.135 with SMTP id cg7mr1414755qab.27.1308284394592; Thu, 16 Jun 2011 21:19:54 -0700 (PDT) Received: by 10.224.80.206 with HTTP; Thu, 16 Jun 2011 21:19:54 -0700 (PDT) In-Reply-To: References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> Date: Fri, 17 Jun 2011 12:19:54 +0800 Message-ID: From: wen heping To: bf1783@gmail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Alexey Dokuchaev , Sahil Tandon , Wen Heping , cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2011 04:19:56 -0000 2011/6/17 b. f. : > On 6/17/11, Sahil Tandon wrote: >> On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: >> >>> On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: >>> > wen =C2=A0 =C2=A0 =C2=A0 =C2=A0 2011-06-16 08:42:28 UTC >>> > >>> > =C2=A0 Modified files: >>> > =C2=A0 =C2=A0 sysutils/tmux =C2=A0 =C2=A0 =C2=A0 =C2=A0Makefile >>> > =C2=A0 Log: >>> > =C2=A0 - Fix build when CFLAGS is set in /etc/make.conf >>> >>> Hmm, default CPPFLAGS is empty. =C2=A0Judging just from the diff, inste= ad of >>> introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which i= s >>> bogus in the first place: -I is preprocessor flag) should be enough (no >>> MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in t= his >>> case as well). =C2=A0I am missing something obvious here? >> >> Because of the way upstream Makefile handles CPPFLAGS, it is not so >> straightforward. =C2=A0This was discussed on freebsd-ports: >> >> =C2=A0http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.= html >> =C2=A0http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.h= tml > > But this does not seem so different from the many other ports that set > or alter variables in the port Makefile. =C2=A0If a user overrides these > changes in an automatically and recursively-included Makefile like > __MAKE_CONF, or on the command-line, it it the user's problem. Users > should not pollute their port builds by unconditionally defining > variables in =C2=A0__MAKE_CONF, and I don't think that we should add > elaborations to ports to avoid such mistakes. =C2=A0If the submitter of > ports/157918 wanted non-default CFLAGS for sysutils/tmux, and he > wanted to define them in __MAKE_CONF, rather than in the other > automatically-included Makefiles (${.CURDIR}/../Makefile.inc, > ${MASTERDIR}/../Makefile.inc, ${MASTERDIR}/Makefile.${ARCH}-${OPSYS}, > ${MASTERDIR}/Makefile.${OPSYS}, ${MASTERDIR}/Makefile.${ARCH}, or > ${MASTERDIR}/Makefile.local), then he could have defined them > conditionally. =C2=A0If he doesn't, he will break many other ports beside= s > systutils/tmux. > > So it seems to me that just fixing CPPFLAGS here is better. We tried just fixing CPPFLAGS, but it fail when define CPPFLAGS in /etc/make.conf. wen > > b. >