Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Aug 2013 19:03:13 GMT
From:      Steve Wall <swall@redcom.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/181120: apache24 patch places "Include" line in the wrong place
Message-ID:  <201308071903.r77J3Dae027937@oldred.freebsd.org>
Resent-Message-ID: <201308071910.r77JA0E7044816@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         181120
>Category:       ports
>Synopsis:       apache24 patch places "Include" line in the wrong place
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 07 19:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Steve Wall
>Release:        9.1
>Organization:
>Environment:
FreeBSD XXXX 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #28 r4604: Mon Jul 29 12:48:20 EDT 2013     root@XXXXX:/usr/obj/space/src/sys/GENERIC  amd64

>Description:
apache24/files/patch-docs__conf__httpd.conf.in includes a chunk that in apache22 placed "Include @rel_sysconfdir@/Includes/*.conf" at the end of httpd.conf.in.  It does not place it at the end in apache24, instead placing it before a (commented out) block of statements that have been added to the file in apache24.

Granted, fairly trivial, but still mildly annoying.  And will probably recur in the future, because diff/patch have no indicator for end-of-file.
>How-To-Repeat:
cd /usr/ports/www/apache24
make
>Fix:
Change the final chunk in apache24/files/patch-docs__conf__httpd.conf.in to this:

@@ -418,3 +418,4 @@
 #RequestHeader unset DNT env=bad_DNT
 #</IfModule>

+Include @rel_sysconfdir@/Includes/*.conf

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308071903.r77J3Dae027937>