Date: Thu, 4 Aug 2022 14:04:27 +0000 From: Ivan Quitschal <tezeka@hotmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: RES: vt newcons 3 clicks mouse paste issue FIXED Message-ID: <CP6P284MB190086D2AD26A14E0C5DA002CB9F9@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> In-Reply-To: <CP6P284MB1900DD45138428B4612DF7ACCB9D9@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> References: <CP6P284MB1900CA1ED5B5BADE054ECB34CBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <f6c1ee1c-bdd9-c8d6-1385-145022e6765d@selasky.org> <CP6P284MB1900CC7B7F6343DAB1D1E5BCCBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <41ef5c38-515f-739a-cb47-7cab0e609526@selasky.org> <CP6P284MB1900DD3D6F41CBAF38CF2CA4CBB29@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM> <20220623014847.067b18a5ba388639cf6009ce@dec.sakura.ne.jp> <fd0f9de9-98ac-87b4-2c9d-5fdc27bdb3c4@selasky.org> <CP6P284MB1900DD45138428B4612DF7ACCB9D9@CP6P284MB1900.BRAP284.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
--_003_CP6P284MB190086D2AD26A14E0C5DA002CB9F9CP6P284MB1900BRAP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Hans D36042 created How can I include more patch files in the same defect number? D36042 https://reviews.freebsd.org/D36042 Its missing the vt.h.diff and vt_core.diff Both attached Should i have put all three in the raw patch creation combo box when I was = creating the defect? Sorry my dumbness , never used that phabricator=20 --tzk > -----Mensagem original----- > De: Ivan Quitschal <tezeka@hotmail.com> > Enviada em: ter=E7a-feira, 2 de agosto de 2022 09:34 > Para: Hans Petter Selasky <hps@selasky.org> > Cc: Tomoaki AOKI <junchoon@dec.sakura.ne.jp>; Ivan Quitschal > <tezeka@hotmail.com>; freebsd-current@freebsd.org; Kurt Jaeger > <pi@freebsd.org> > Assunto: vt newcons 3 clicks mouse paste issue FIXED >=20 >=20 > Hi guys >=20 > Currently , if you click 3 times in order to select the entire row, its j= ust not > working as it should. > i fixed that please find below and attached the patches >=20 > With this change now we can do a 3 clicks and paste , i dont know, in som= e > command, and it will be executed just fine, like it was in syscons, and s= till is in > xterm/ linux etc >=20 > now if the event is a 3 mouse clickss select, the space trim is made on t= he right > and an <enter> is included >=20 > thanks >=20 > --tzk >=20 >=20 > -------------------- > --- sys/dev/vt/vt_buf.c.orig 2022-08-02 08:44:27.229782000 -0300 > +++ sys/dev/vt/vt_buf.c 2022-08-02 08:45:02.703697000 -0300 > @@ -771,7 +771,7 @@ > } >=20 > void > -vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz) > +vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz, int > +mark) > { > int i, j, r, c, cs, ce; > term_pos_t s, e; > @@ -799,7 +799,7 @@ > buf[i++] =3D vb->vb_rows[r][c]; >=20 > /* For all rows, but the last one. */ > - if (r !=3D e.tp_row) { > + if (r !=3D e.tp_row || mark =3D=3D VTB_MARK_ROW) { > /* Trim trailing word separators, if any. */ > for (; i !=3D j; i--) { > if (!tchar_is_word_separator(buf[i - 1])= ) > -------------------- >=20 > --- sys/dev/vt/vt_core.c.orig 2022-08-02 08:43:15.436415000 -0300 > +++ sys/dev/vt/vt_core.c 2022-08-02 08:43:49.120096000 -0300 > @@ -2287,7 +2287,7 @@ > VD_PASTEBUFSZ(vd) =3D len; > } > /* Request copy/paste buffer data, no more than `len' */ > - vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len); > + vtbuf_extract_marked(&vw->vw_buf, VD_PASTEBUF(vd), len, > + mark); >=20 > VD_PASTEBUFLEN(vd) =3D len; >=20 > --------------------- >=20 > --- sys/dev/vt/vt.h.orig 2022-08-02 08:41:23.888584000 -0300 > +++ sys/dev/vt/vt.h 2022-08-02 08:41:54.504309000 -0300 > @@ -238,7 +238,7 @@ > #ifndef SC_NO_CUTPASTE > int vtbuf_set_mark(struct vt_buf *vb, int type, int col, int row); > int vtbuf_get_marked_len(struct vt_buf *vb); -void > vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz); > +void vtbuf_extract_marked(struct vt_buf *vb, term_char_t *buf, int sz, > +int > mark); > #endif >=20 > #define VTB_MARK_NONE 0 > -------------------------- --_003_CP6P284MB190086D2AD26A14E0C5DA002CB9F9CP6P284MB1900BRAP_ Content-Type: application/octet-stream; name="vt.h.diff" Content-Description: vt.h.diff Content-Disposition: attachment; filename="vt.h.diff"; size=478; creation-date="Thu, 04 Aug 2022 14:02:00 GMT"; modification-date="Thu, 04 Aug 2022 14:04:26 GMT" Content-Transfer-Encoding: base64 LS0tIHN5cy9kZXYvdnQvdnQuaC5vcmlnCTIwMjItMDgtMDIgMDg6NDE6MjMuODg4NTg0MDAwIC0w MzAwDQorKysgc3lzL2Rldi92dC92dC5oCTIwMjItMDgtMDIgMDg6NDE6NTQuNTA0MzA5MDAwIC0w MzAwDQpAQCAtMjM4LDcgKzIzOCw3IEBADQogI2lmbmRlZiBTQ19OT19DVVRQQVNURQ0KIGludCB2 dGJ1Zl9zZXRfbWFyayhzdHJ1Y3QgdnRfYnVmICp2YiwgaW50IHR5cGUsIGludCBjb2wsIGludCBy b3cpOw0KIGludCB2dGJ1Zl9nZXRfbWFya2VkX2xlbihzdHJ1Y3QgdnRfYnVmICp2Yik7DQotdm9p ZCB2dGJ1Zl9leHRyYWN0X21hcmtlZChzdHJ1Y3QgdnRfYnVmICp2YiwgdGVybV9jaGFyX3QgKmJ1 ZiwgaW50IHN6KTsNCit2b2lkIHZ0YnVmX2V4dHJhY3RfbWFya2VkKHN0cnVjdCB2dF9idWYgKnZi LCB0ZXJtX2NoYXJfdCAqYnVmLCBpbnQgc3osIGludCBtYXJrKTsNCiAjZW5kaWYNCiANCiAjZGVm aW5lCVZUQl9NQVJLX05PTkUJCTANCg== --_003_CP6P284MB190086D2AD26A14E0C5DA002CB9F9CP6P284MB1900BRAP_ Content-Type: application/octet-stream; name="vt_core.diff" Content-Description: vt_core.diff Content-Disposition: attachment; filename="vt_core.diff"; size=413; creation-date="Thu, 04 Aug 2022 14:02:00 GMT"; modification-date="Thu, 04 Aug 2022 14:04:26 GMT" Content-Transfer-Encoding: base64 LS0tIHN5cy9kZXYvdnQvdnRfY29yZS5jLm9yaWcJMjAyMi0wOC0wMiAwODo0MzoxNS40MzY0MTUw MDAgLTAzMDANCisrKyBzeXMvZGV2L3Z0L3Z0X2NvcmUuYwkyMDIyLTA4LTAyIDA4OjQzOjQ5LjEy MDA5NjAwMCAtMDMwMA0KQEAgLTIyODcsNyArMjI4Nyw3IEBADQogCQkJVkRfUEFTVEVCVUZTWih2 ZCkgPSBsZW47DQogCQl9DQogCQkvKiBSZXF1ZXN0IGNvcHkvcGFzdGUgYnVmZmVyIGRhdGEsIG5v IG1vcmUgdGhhbiBgbGVuJyAqLw0KLQkJdnRidWZfZXh0cmFjdF9tYXJrZWQoJnZ3LT52d19idWYs IFZEX1BBU1RFQlVGKHZkKSwgbGVuKTsNCisJCXZ0YnVmX2V4dHJhY3RfbWFya2VkKCZ2dy0+dndf YnVmLCBWRF9QQVNURUJVRih2ZCksIGxlbiwgbWFyayk7DQogDQogCQlWRF9QQVNURUJVRkxFTih2 ZCkgPSBsZW47DQogDQo= --_003_CP6P284MB190086D2AD26A14E0C5DA002CB9F9CP6P284MB1900BRAP_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CP6P284MB190086D2AD26A14E0C5DA002CB9F9>