From owner-freebsd-gnome@FreeBSD.ORG Sun Jun 24 12:23:15 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D62A61065670 for ; Sun, 24 Jun 2012 12:23:15 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from fep15.mx.upcmail.net (fep15.mx.upcmail.net [62.179.121.35]) by mx1.freebsd.org (Postfix) with ESMTP id 2784F8FC0C for ; Sun, 24 Jun 2012 12:23:14 +0000 (UTC) Received: from edge02.upcmail.net ([192.168.13.237]) by viefep15-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20120624122307.TLGL18555.viefep15-int.chello.at@edge02.upcmail.net>; Sun, 24 Jun 2012 14:23:07 +0200 Received: from [192.168.0.132] ([77.250.114.160]) by edge02.upcmail.net with edge id SCP61j0073TiT9102CP6RP; Sun, 24 Jun 2012 14:23:07 +0200 X-SourceIP: 77.250.114.160 Message-ID: <1340540585.1577.2.camel@crashalot.rainbow-runner.nl> From: Koop Mast To: Ruslan Mahmatkhanov Date: Sun, 24 Jun 2012 14:23:05 +0200 In-Reply-To: <4FE61DDC.9050807@yandex.ru> References: <1340403295.2825.3.camel@localhost> <1340461437.73169.2.camel@localhost> <4FE61DDC.9050807@yandex.ru> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.4.3 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: System->Administration->anything doesn't work... X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2012 12:23:15 -0000 On Sat, 2012-06-23 at 23:49 +0400, Ruslan Mahmatkhanov wrote: > Mike Harding wrote on 23.06.2012 18:23: > > To answer my own question: > [...] > > > > The error is obvious in context, missing ','. > > > > "freebsd-8" => [ "FreeBSD", "8", "" ], > > "freebsd-9" => [ "FreeBSD", "9", "" ], > > "freebsd-10" => [ "FreeBSD", "10" "" ], <- Look, Ma, missing > > comma > > "gentoo" => [ "Gentoo Linux", "", "" ], > > > > This has been broken for 3 months! > > This was introduced in a patch from ports/166147 by yours truly. Sorry > about that and thank you for the good catch. I can confirm that this > change fixes System->Administration menu for me on -current. > > Joe, Koop, Jeremy, would you please commit/approve this? Done, thanks for reporting Mike.