From owner-freebsd-sparc64@FreeBSD.ORG Tue Mar 22 21:13:40 2011 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAE19106566C; Tue, 22 Mar 2011 21:13:40 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 1C2A38FC1A; Tue, 22 Mar 2011 21:13:39 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B51BB45E49; Tue, 22 Mar 2011 22:13:38 +0100 (CET) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9192745683; Tue, 22 Mar 2011 22:13:33 +0100 (CET) Date: Tue, 22 Mar 2011 22:13:26 +0100 From: Pawel Jakub Dawidek To: Marius Strobl Message-ID: <20110322211326.GC1882@garage.freebsd.pl> References: <20110307192239.GA31314@alchemy.franken.de> <20110310185423.GA50419@alchemy.franken.de> <20110319152838.GA8594@alchemy.franken.de> <20110321175632.GA19345@darkthrone.kvedulv.de> <20110321175933.GD2086@garage.freebsd.pl> <20110322191117.GH15528@alchemy.franken.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/e2eDi0V/xtL+Mc8" Content-Disposition: inline In-Reply-To: <20110322191117.GH15528@alchemy.franken.de> User-Agent: Mutt/1.4.2.3i X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Roger Hammerstein , freebsd-sparc64@freebsd.org, mm@freebsd.org Subject: Re: sparc64 hang with zfs v28 X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2011 21:13:40 -0000 --/e2eDi0V/xtL+Mc8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 22, 2011 at 08:11:17PM +0100, Marius Strobl wrote: > On Tue, Mar 22, 2011 at 01:51:20PM -0400, Roger Hammerstein wrote: > >=20 > > which is: > > 1310: > > 1311: error =3D put_nvlist(zc, configs); > > 1312: > > 1313: nvlist_free(configs); > > 1314: > > 1315: return (error); > > 1316:} > > 1317: > >=20 >=20 > Uhm, looks like r219089 changed some xcopy{in,out}() into > ddi_copy{in,out}(), i.e. copy{in,out}() into bcopy(), which > is just wrong for copying in data in from/out to userspace. > However, looking at the other uses of ddi_copy{in,out}() it > generally seems that ddi_copy{in,out}() should be defined to > copy{in,out}(). With the attached patch at least my simple > test cases works again. The one remaining xcopyout() in > zfs_ioctl.c then could be also replaced with a ddi_copyout(). > Not sure how any of this manages to work on x86 :) Yeah, I found this as well and waiting for my test machine to be free to test it. Thanks. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --/e2eDi0V/xtL+Mc8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk2JEPYACgkQForvXbEpPzSfUwCfTuyZvY82oD1qq34nFbcw/FIb DrwAoJHrz/HYOQx7+KZw6Dm8Hvu4Rt1T =yUBm -----END PGP SIGNATURE----- --/e2eDi0V/xtL+Mc8--