From owner-freebsd-stable@FreeBSD.ORG  Sun Aug 22 13:08:56 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 22EB61065693
	for <freebsd-stable@freebsd.org>; Sun, 22 Aug 2010 13:08:56 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de
	[217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id D4BFA8FC19
	for <freebsd-stable@freebsd.org>; Sun, 22 Aug 2010 13:08:55 +0000 (UTC)
Received: from outgoing.leidinger.net (p5B32F045.dip.t-dialin.net
	[91.50.240.69])
	by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id E9E5484400C;
	Sun, 22 Aug 2010 15:08:50 +0200 (CEST)
Received: from unknown (unknown [192.168.2.110])
	by outgoing.leidinger.net (Postfix) with ESMTP id 4E5BC15EE;
	Sun, 22 Aug 2010 15:08:45 +0200 (CEST)
Date: Sun, 22 Aug 2010 15:08:42 +0200
From: Alexander Leidinger <Alexander@Leidinger.net>
To: jhell <jhell@DataIX.net>
Message-ID: <20100822150842.00005129@unknown>
In-Reply-To: <4C6F5344.6040808@DataIX.net>
References: <4C6F5344.6040808@DataIX.net>
X-Mailer: Claws Mail 3.7.2cvs15 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-EBL-MailScanner-Information: Please contact the ISP for more information
X-EBL-MailScanner-ID: E9E5484400C.A3354
X-EBL-MailScanner: Found to be clean
X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN,
	SpamAssassin (not cached, score=-0.923, required 6,
	autolearn=disabled, ALL_TRUSTED -1.00, TW_ZF 0.08)
X-EBL-MailScanner-From: alexander@leidinger.net
X-EBL-MailScanner-Watermark: 1283087334.11183@ls1taVt8Xacda7tWmurRCw
X-EBL-Spam-Status: No
Cc: FreeBSD Stable <freebsd-stable@freebsd.org>
Subject: Re: daily run output 800.scrub-zfs fixups
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Aug 2010 13:08:56 -0000

On Sat, 21 Aug 2010 00:17:08 -0400 jhell <jhell@DataIX.net> wrote:

> 
> Hi Alexander,
> 
> Attached is a fix for one problem and one slight overlook for
> 800.scrub-zfs.
> 
> The first & second change was probably just an oversight but none the
> less they both give a false impression of actions taken.
> 
> Change1:
> 	${daily_scrub_zfs_default_threshold=30} is missng the ':'
> which would ultimately reset the users supplied value in
> periodic.conf to 30.

Sorry, but it is not missing the ':'. There is one in front of it. A
lot of start scripts in ports use this. You need to use a := instead of
a = if you use
  var=${var:=default_val}
but not if you use
  : ${var=default_val}

I have the impression that the ':' in front of the variable is the way
it is supposed to be in the start scripts in ports. I adopted this
style (one variable name less to type... specially with expressive
names this is some amount less to type).

And I remember to have tested a lot of cases for the timeout value,
overriding a pool specific value and overriding the default where some
of them and all worked.

If you have a case where it does not work, it would be nice if you
could add a "set -x" in the beginning of the script and send me the
output of a failing run.

Bye,
Alexander.