Date: Thu, 12 Feb 2004 10:28:45 +0000 From: Eivind Eklund <eivind@FreeBSD.org> To: Trevor Johnson <trevor@jpj.net> Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Subject: Re: cvs commit: ports/www/firefox Makefile distinfo pkg-descr pkg-message pkg-plist ports/www/firefox/files firebird.rb firefox.rb mkdistfile mozconfig.in patch-Double.cpp patch-build_unix_run-mozilla Message-ID: <20040212102842.GC3148@FreeBSD.org> In-Reply-To: <20040212031228.E31447@blues.jpj.net> References: <200402110716.i1B7GH9D017803@repoman.freebsd.org> <xzpisidbtvn.fsf@dwp.des.no> <1076508074.88428.14.camel@pav.hide.vol.cz> <20040211122704.X93022@blues.jpj.net> <xzpk72tiah1.fsf@dwp.des.no> <20040211165940.Q98525@blues.jpj.net> <xzp4qtweqlf.fsf@dwp.des.no> <20040212031228.E31447@blues.jpj.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 12, 2004 at 03:38:18AM -0500, Trevor Johnson wrote:
> > IMHO, replacing ${REINPLACE_CMD} with ${PERL} -pi is a regression.
>
> Were this the only place where the port uses Perl, you would be right.
My opinion is that DES is right anyway. This lowers the consistency of
the ports tree overall, and it makes it harder to do global statistics
etc. For each single issue this is not a big deal; however, overall it
IS, and to get overall consistency we need to make consistent choices in
each single case.
At least 99% of the people that still run 4.6 and want to run firefox
will already have REINPLACE installed. The argument for "less
dependencies" is thus for an extreme minority case, and it is IMO not
one we should take particular care for anyway. We *want* people to
upgrade, so the net avoids exposure to old versions etc.
My advice: Just accept the use of perl as a mistake, fix it, and move
on.
Eivind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040212102842.GC3148>