From owner-svn-src-head@freebsd.org Fri Feb 19 00:38:36 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76ED9AABE6E; Fri, 19 Feb 2016 00:38:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 5BD3E161C; Fri, 19 Feb 2016 00:38:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 5456C1E4E; Fri, 19 Feb 2016 00:38:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 0D206D30E; Fri, 19 Feb 2016 00:38:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id z4YbRENfH7Pg; Fri, 19 Feb 2016 00:38:33 +0000 (UTC) Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 32E1CD309 To: Maxim Sobolev , ray@FreeBSD.org, Adrian Chadd References: Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56C66415.7040407@FreeBSD.org> Date: Thu, 18 Feb 2016 16:38:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="I9bq3CGk4fSkOR85HrdibXEW1k4UPQNXt" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 00:38:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I9bq3CGk4fSkOR85HrdibXEW1k4UPQNXt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/18/2016 3:57 PM, Maxim Sobolev wrote: > Aleksandr, Adrian, >=20 > I know it's 3 years later, but I really don't know why it's been done > this way. Take a GEOM module and associated usr.bin utility, copy it > verbatim add few lines of code and re-add that as a new module seems > like just laziness and attempt to avoid doing extra work on making > unified code. The same goes for the mkulzma, which is almost 1:1 copy o= f > the mkuzip. Now people are merging back and forth and I've just spent > few days testing some rather major rework of geom_uzip / mkuzip code no= t > even realizing that there is its evil twin in the tree. :( r283104 is an example of one of these problems. It was a catch-up of uzip's r268986 done almost a year before. I did comparisons before using uzip last summer and ran across that one. >=20 > https://reviews.freebsd.org/D5333 >=20 > I suggest functionality from both geom_uncompress / mkulzma are folded > now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuke= d > afterwards. >=20 > Thanks! >=20 > =20 >=20 > Author: ray > Date: Wed Jan 4 23:39:11 2012 > New Revision: 229537 > URL: http://svn.freebsd.org/changeset/base/229537 > Log: > GEOM_UNCOMPRESS module, can be used with uzip images and with new > ulzma images. > Approved by: adrian (mentor) > Added: > head/sys/geom/uncompress/ > head/sys/geom/uncompress/g_uncompress.c (contents, props changed) > head/sys/modules/geom/geom_uncompress/ > head/sys/modules/geom/geom_uncompress/Makefile (contents, props cha= nged) > Modified: > head/sys/conf/files > head/sys/conf/options >=20 >=20 --=20 Regards, Bryan Drewery --I9bq3CGk4fSkOR85HrdibXEW1k4UPQNXt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWxmQVAAoJEDXXcbtuRpfPEUQIANj8xQVUQnR2qxXwq499expN 2pS4EDSM4xLOBcNnyGq37Z33T1LuNSUMLeQ660s4RPcfT8YL9gpbRrAXnNELFYa4 R4EFwElr6UEs9w2cgzdQ3RkkCf5OFfIGevA1pm2LUKPUoyR/BsnLEXeoZ8KK+7f2 5SAAz+3C9+77VKzOm0a/x7D9O7m4pTpl24hkNoPpK3+6D974eN1hj8puJHKrtD2W +VRnu/CFVPqNCaasS8o1vQ4xIRS8xXsctOXaactsXmBI7IZC5+XnAO+0Yh21kv35 Cr0zUBjSoPfRNq/DGzn3IeEc1qzUcM1xN1rVW5ELNzppaV5U+5E1ctpau2Sfnas= =h7yM -----END PGP SIGNATURE----- --I9bq3CGk4fSkOR85HrdibXEW1k4UPQNXt--