From owner-cvs-src@FreeBSD.ORG Fri Jun 10 19:03:47 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DD7216A420 for ; Fri, 10 Jun 2005 19:03:47 +0000 (GMT) (envelope-from ups@freebsd.org) Received: from smtp.speedfactory.net (talon.speedfactory.net [66.23.216.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15E8A43D4C for ; Fri, 10 Jun 2005 19:03:46 +0000 (GMT) (envelope-from ups@freebsd.org) Received: (qmail 17089 invoked from network); 10 Jun 2005 19:03:48 +0000 Received: from 66-23-216-49.clients.speedfactory.net (HELO palm.tree.com) (66.23.216.49) by smtp.speedfactory.net with AES256-SHA encrypted SMTP; 10 Jun 2005 19:03:48 +0000 Received: from [127.0.0.1] (ups@localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id j5AJ3ipP001947; Fri, 10 Jun 2005 15:03:44 -0400 (EDT) (envelope-from ups@freebsd.org) From: Stephan Uphoff To: John Baldwin In-Reply-To: References: <200506091826.j59IQVMe054446@repoman.freebsd.org> <00b08fa8e580e95a2c5ecd95c54a9805@FreeBSD.org> <1118371501.27369.45718.camel@palm> Content-Type: text/plain Message-Id: <1118430224.27369.54685.camel@palm> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 10 Jun 2005 15:03:44 -0400 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 19:03:47 -0000 On Fri, 2005-06-10 at 12:50, John Baldwin wrote: > On Jun 9, 2005, at 7:45 PM, Stephan Uphoff wrote: > > > On Thu, 2005-06-09 at 19:28, John Baldwin wrote: > >> On Jun 9, 2005, at 11:26 AM, Stephan Uphoff wrote: > >> > >>> ups 2005-06-09 18:26:31 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/kern kern_switch.c sched_4bsd.c > >>> Log: > >>> Fix some race conditions for pinned threads that may cause them to > >>> run > >>> on the wrong CPU. > >>> > >>> Add IPI support for preempting a thread on another CPU. > >>> > >>> MFC after:3 weeks > >> > >> Note that this breaks the compile on non x86 when PREEMPTION isn't on > > > > I compiled/tested it also without PREEMPTION on x86. > > Could you send me the error message? > > I mistyped, I meant when preemption is on. The Alpha tinderbox is > keeling over now due to the missing IPI_PREEMPT. I can try to add > IPI_PREEMPT in next week or so. Thanks - found it. This is a LINT only problem. OK to fix it like this? : RCS file: /cvsroot/src/sys/conf/NOTES,v retrieving revision 1.1322 diff -u -r1.1322 NOTES --- NOTES 9 Jun 2005 18:59:21 -0000 1.1322 +++ NOTES 10 Jun 2005 19:01:55 -0000 @@ -231,7 +231,7 @@ # WITNESS_SKIPSPIN disables the witness checks on spin mutexes. options PREEMPTION options FULL_PREEMPTION -options IPI_PREEMPTION +#options IPI_PREEMPTION options MUTEX_DEBUG options WITNESS options WITNESS_KDB