From owner-dev-commits-src-main@freebsd.org Sat May 8 00:04:33 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5DF5D640F7C for ; Sat, 8 May 2021 00:04:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcSH51jx4z3mJk for ; Sat, 8 May 2021 00:04:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id i17so10299471qki.3 for ; Fri, 07 May 2021 17:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BlBLYj/QMb5uDGfLaOpMe1nz32IEcqltH416lfud9Nw=; b=qqofcFErcWJ3HwgkJuqgPQ/VkUfvBmlTSmA2sU/9Y11a4FKs/x9iM1QzGFxMTyjDdD 6zyIhjxYYdZJrLCXJi36W2U5AE7BRGSIVLrG7Bps9/d7GIRKI+XJ3ocDH/BPWYgID4+q IsnWRKMWERi6k5vcisa07TAnO2naCa0I9yRyDIfezMNvyO40D8jexAEhcewppuCD2zTL EbFQBBrMbVfGnWBS2AT8R6qE088gILSxGcmubV39uh141Xm93g/D4hnUhwX3ZndeKjEM JQr/lI2TN0AZDHmzpxVLTQ47GtiZyP9of+2zRj8w6HPMdiMjmudKm3Juouuu3d0wrHFw owTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BlBLYj/QMb5uDGfLaOpMe1nz32IEcqltH416lfud9Nw=; b=hotaKuDIsErNc0ANXl3bvh+XXZTVB4auaQm+Hhl6iW1kJ3dGw5on/cSCbj+iegPmPf pJNicQWbzyoJYKOFGCCczqWHwrER4hY7Qhsh/CYZAkuvq4kF7esCKdlWeJKFqLGfDx6y Lk/ugY8TUwy//6FhatISbFrO54Y4Cy4BwFPsF2LHGJeJ1Km2CT/c8mL2O1m8wdedBW0z Cahfr0eaiIucIHJL1ilT6/NghNlutytipiZG2iS4qAxYun2qbF/EeLxVr6iWnSgnDZrT UDdHEgVwX8HYUFeXhQdrxFyeUe4FxjjRNvV5Y7CwFxebxQu6a7s1Nc8mzdMmPBaZFD7t Tw5w== X-Gm-Message-State: AOAM530KQnnD1Frti1ikn3Ro+YonxfR/JqxKR3XC9UA56NLcIBMB9AtK jKo3nz+qevQtvmcO04FGekjpt7wCYcTAvBD4xiOY3Q== X-Google-Smtp-Source: ABdhPJxRdvnr8oVekwU4EbiUT/2DVzX4yP24juKn2wzP0HM8p5QeiAttoVLFtnPIUTgFxME9A1uyBJsZdTtlMypidOA= X-Received: by 2002:a37:c444:: with SMTP id h4mr9727283qkm.206.1620432271472; Fri, 07 May 2021 17:04:31 -0700 (PDT) MIME-Version: 1.0 References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> <78FF7B31-B84D-4D97-9E57-D000A6B09D7D@macmic.franken.de> <504C85E6-8967-40CC-8E12-F20F78B3226F@macmic.franken.de> In-Reply-To: <504C85E6-8967-40CC-8E12-F20F78B3226F@macmic.franken.de> From: Warner Losh Date: Fri, 7 May 2021 18:04:19 -0600 Message-ID: Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. To: Michael Tuexen Cc: Gordon Bergling , Li-Wen Hsu , Randall Stewart , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FcSH51jx4z3mJk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2021 00:04:33 -0000 On Fri, May 7, 2021, 12:38 PM Michael Tuexen < michael.tuexen@macmic.franken.de> wrote: > > On 7. May 2021, at 20:26, Warner Losh wrote: > > > > https://reviews.freebsd.org/D30163 > > > > May be the ticket to solve this... > I don't understand that. RACK should just compile fine when RATELIMIT is > defined > in the kernel config. Gordon states that this is the case for him. > Whu do you think that D30163 is needed to compile RACK on a platform where > RATELIMIT is in the kernel config? > We need ot to compile the module when it isn't in the kernel. Modules have to compile, even for illegal combinations of options or be omitted from building... Warner Best regards > Michael > > > > Warner > > > > On Fri, May 7, 2021, 12:03 PM Michael Tuexen < > michael.tuexen@macmic.franken.de> wrote: > > > On 7. May 2021, at 19:47, Gordon Bergling wrote: > > > > > > On Fri, May 07, 2021 at 05:39:37PM +0800, Li-Wen Hsu wrote: > > >> On Thu, May 6, 2021 at 11:26 PM Randall Stewart > wrote: > > >>> > > >>> The branch main has been updated by rrs: > > >>> > > >>> URL: > https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe > > >>> > > >>> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > > >>> Author: Randall Stewart > > >>> AuthorDate: 2021-05-06 15:22:26 +0000 > > >>> Commit: Randall Stewart > > >>> CommitDate: 2021-05-06 15:22:26 +0000 > > >>> > > >>> This brings into sync FreeBSD with the netflix versions of rack > and bbr. > > >>> This fixes several breakages (panics) since the tcp_lro code was > > >>> committed that have been reported. Quite a few new features are > > >>> now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > > >>> largest). There is also support for ack-war prevention. Documents > > >>> comming soon on rack.. > > >>> > > >>> Sponsored by: Netflix > > >>> Reviewed by: rscheff, mtuexen > > >>> Differential Revision: https://reviews.freebsd.org/D30036 > > >> > > >> This seems braking LINT kernel build of powerpc: > > >> > > >> https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console > > >> > > >> Searching "error:" leads to: > > >> > > >> 00:08:15.153 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > > >> error: implicit declaration of function 'tcp_hw_highest_rate' is > > >> invalid in C99 [-Werror,-Wimplicit-function-declaration] > > >> 00:08:15.153 high_rate = > > >> tcp_hw_highest_rate(rack->r_ctl.crte); > > >> 00:08:15.153 ^ > > >> > > >> and > > >> > > >> 00:08:15.163 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > > >> error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > > >> invalid in C99 [-Werror,-Wimplicit-function-declaration] > > >> 00:08:15.163 high_rate = > > >> tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > > >> rack->rc_inp); > > >> 00:08:15.163 ^ > > >> > > >> I suspect this is because RATELIMIT is not defined in default powerpc > > >> build? Is it safe to enable it? > > >> > > >> Best, > > >> Li-Wen > > > > > > That should not be something RATELIMT related. I regular test > 14-CURRENT on a > > > RPi4B and the build today fails with > > > > > > -------------------------------------------------------------- > > >>>> stage 3.1: building everything > > > -------------------------------------------------------------- > > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in > C99 [-Werror,-Wimplicit-function-declaration] > > > high_rate = > tcp_hw_highest_rate(rack->r_ctl.crte); > > > ^ > > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > > high_rate = > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > rack->rc_inp); > > > ^ > > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14166:15: > error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in > C99 [-Werror,-Wimplicit-function-declaration] > > > high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); > > > ^ > > > > /tank/nfs_public/tiny/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:14193:15: > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > > high_rate = > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > rack->rc_inp); > > > ^ > > > 4 errors generated. > > > --- rack.o --- > > > *** [rack.o] Error code 1 > > > > > > > > > RATELIMIT is included in my KERNCONF since I use tcp_bbr(4) for a > > > while on the RPi4B now. > > Can you post the kernel config you are using? I'm building the kernel on > an arm64 platform by using > > > > tuexen@parallels:~/freebsd-src/sys/arm64/conf % cat SCTP > > include GENERIC > > ident SCTP > > > > makeoptions WITH_EXTRA_TCP_STACKS=1 > > options SCTP > > options SCTP_DEBUG > > options TCPHPTS > > options TCP_BLACKBOX > > options RATELIMIT > > options DEBUG_REDZONE > > options IPFIREWALL > > options IPFIREWALL_VERBOSE > > options IPFIREWALL_VERBOSE_LIMIT=5 > > options IPFIREWALL_DEFAULT_TO_ACCEPT > > > > It looks like RATELIMIT is not defined, when tcp_ratelimit.h is > included... > > > > Best regards > > Michael > > > > > --Gordon > > > >