From owner-freebsd-current@FreeBSD.ORG Sat Aug 10 18:25:02 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 523C4352; Sat, 10 Aug 2013 18:25:02 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from mail0.glenbarber.us (mail0.glenbarber.us [IPv6:2607:fc50:1:2300:1001:1001:1001:face]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 211632980; Sat, 10 Aug 2013 18:25:02 +0000 (UTC) Received: from glenbarber.us (nucleus.glenbarber.us [IPv6:2001:470:8:1205:2:2:ff:29]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gjb) by mail0.glenbarber.us (Postfix) with ESMTPSA id E1C00C26C; Sat, 10 Aug 2013 18:25:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.8.3 mail0.glenbarber.us E1C00C26C Authentication-Results: mail0.glenbarber.us; dkim=none reason="no signature"; dkim-adsp=none Date: Sat, 10 Aug 2013 14:24:59 -0400 From: Glen Barber To: Dan Mack Subject: Re: nanobsd-built system doesn't have SVN revision in "uname" (and it looks like regression) Message-ID: <20130810182459.GF2432@glenbarber.us> References: <383656436.20130810150849@serebryakov.spb.ru> <37152758.20130810151846@serebryakov.spb.ru> <602958881.20130810180203@serebryakov.spb.ru> <20130810141324.GD2432@glenbarber.us> <529930061.20130810191339@serebryakov.spb.ru> <20130810181152.GE2432@glenbarber.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GV0iVqYguTV4Q9ER" Content-Disposition: inline In-Reply-To: <20130810181152.GE2432@glenbarber.us> X-Operating-System: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Lev Serebryakov , freebsd-embedded@freebsd.org, freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 18:25:02 -0000 --GV0iVqYguTV4Q9ER Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 10, 2013 at 02:11:52PM -0400, Glen Barber wrote: > On Sat, Aug 10, 2013 at 01:09:20PM -0500, Dan Mack wrote: > > It looks like you are doing the first [! -z '"${svnversion}"' ] > > before $svnversion is being set. In the old version, this was > > being set via: > >=20 > > if [ -x /usr/bin/svnliteversion ] ; then > > svnversion=3D/usr/bin/svnliteversion > > fi > >=20 > > But I'm not sure if that's intentional or not ... > >=20 >=20 > Ugh. No, this was not intentional. I'll have this fixed shortly. >=20 Fixed in r254184. The problem is that I was evaluating ${svnversion} being set before looking for /usr/bin/svnliteversion; however when _running_ /usr/bin/svnliteversion, it was being run as /usr/bin/svnversion by mistake. Thank you for the reports, and Dan, thank you for your help. Glen --GV0iVqYguTV4Q9ER Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJSBoV7AAoJEFJPDDeguUajcdkIAK7KFqFppIpLq2+Ws1qcsPDI ddvJ8BaSGRFQKK3UHfxnJbbyIImKn4nsoQU9sFq+pgo91leIapWYuobLUAJCYs// A72A5yoEL5tuMiyIK/h0Sd0DHWYnRPn/HXEh/rXXOihuMp38+AF0Vb0+RyoPz6/N anvcQZosvNtziE7uybQUZoAyPw66+VW7SDNVxivYEEhcUbIKAFUShud4yU88HKpS FfNBBsPUA/k9UVBjJdlVC4LOuucmwnx9ToKhS5SoWQLxo6nud1lzPidPeIBt2t5R PmVGFs7ih6xa6+3P2PV+DcQvvBGgkDKbaW3QcqBNe6zrLilgfHS3Fk0pIsEF5gg= =m02a -----END PGP SIGNATURE----- --GV0iVqYguTV4Q9ER--