From owner-svn-src-head@freebsd.org Sun Oct 29 05:27:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 670E0E598CF; Sun, 29 Oct 2017 05:27:00 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 344A76BDDF; Sun, 29 Oct 2017 05:27:00 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-pg0-x22a.google.com with SMTP id y5so8475500pgq.7; Sat, 28 Oct 2017 22:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=SjBIhgsJvT1Mveu0UZdHBHb5rBaFPwAGcOp+YjJ6DTE=; b=BghhA7kfnie7aGt7+8QNECNCtxa1m5BEjc+6sK6CeNDBf26UU6lGfIVGMkBqTK/OL8 OMvk3fA3GuDUYde5tgWMutQuNKbj0ZOcAlrWnIQPonARU6lqdC2UB5VESn8pUuLMA0NT MQNOxVUMgU/z9IMiBmRPmhPQ4lJup4ED1uPL1ZqiySHxq7A7ZV/KwI7JmkIg12OnLHHo 6UZrP8Z6x1r4TOUb6nw/zHDMpHIi0sqm2jUqWNydBY6HywUiLt2kP7b1fXBK3YqrIItn 1OYAvZhnp3CalMR8RA6e504qhtfgYcGKHZ4DFoBgvAmypNC7ibgROhvwNdx+t3sBSf6U MnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=SjBIhgsJvT1Mveu0UZdHBHb5rBaFPwAGcOp+YjJ6DTE=; b=OgUt9ISFCXqQGikotF7myx/R+TPdK6+kZdkYsxg3qwE10tNPTSs1SDRIinDYHEgeIs YmJEk9Y9hPdcf8u/AaUdaF9a2nXeOwLKJBSbpu71DX5Qfx2MqRdTEpgdbbXAL8Q5xJSD th4A8fzHB2aguI9baWDcRjZHSlCfnvpabez+3ZGG128y3+ozkMD00O3IGDQtfdYIXmeC B/nud3daDuaM0hJkri881KC3/tmKcm8KGvW7xBJjRCu7tX6pOvPdDCFFLDjmCHqhJjMQ c7JmcHM5lVw1cDCCO2rDmAwz34CvEvGGGgkh906K/6689KMTfxjmKm8PMiDmGE662wvm 5ZqA== X-Gm-Message-State: AMCzsaV7MpUJTFd7V9czH2Cx+DcqoGIvxJ2vWfoogPYOeiju1AsB4bum iW0NrTSmpYMHvVPXhX1fGOoMyMShIIcqlmtOc6fkzq6m X-Google-Smtp-Source: ABhQp+TyFf4Y+a4EF3r2/HwIzpfTNu6QxlOJqaEOthJUuv7BUG3LkYa0fAlZ/Niy1+oerF0Io5REQxADyJ2wTGsXNA4= X-Received: by 10.84.128.70 with SMTP id 64mr4213926pla.329.1509254819453; Sat, 28 Oct 2017 22:26:59 -0700 (PDT) MIME-Version: 1.0 Sender: oshogbo.vx@gmail.com Received: by 10.100.130.73 with HTTP; Sat, 28 Oct 2017 22:26:58 -0700 (PDT) In-Reply-To: References: <201710281923.v9SJNvE5021346@repo.freebsd.org> From: Mariusz Zaborski Date: Sun, 29 Oct 2017 06:26:58 +0100 X-Google-Sender-Auth: nuFb-KnIIAVU8xzgsCrv78wZKVE Message-ID: Subject: Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_g... To: cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 05:27:00 -0000 On 29 October 2017 at 01:49, Conrad Meyer wrote: > Hi, > > On Sat, Oct 28, 2017 at 12:23 PM, Mariusz Zaborski = wrote: >> Author: oshogbo >> Date: Sat Oct 28 19:23:57 2017 >> New Revision: 325062 >> URL: https://svnweb.freebsd.org/changeset/base/325062 >> >> Log: >> Introduce caspermocks. >> >> The idea behinds mocks is that we don't need to ifdef a lot of code in >> tools itself but those defines are hidden in the casper library. >> Right now the mocks are implemented as define/inlines functions. >> There was a very long discussion how this should be implemented. >> This approach has some advantages like we don't need to link to any ad= ditional >> libraries. Unfortunately there are also some disadvantages for example= it is >> easy to get library out of sync between two versions of functions or t= hat we >> need extra define to compile program with casper support. >> This isn't an ideal solution but it's good enough for now and should s= implify >> capsicumizing programs. This also doesn't close us any other ways to d= o those >> mocks and this should evolve in time. >> >> Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery >> Differential Revision: https://reviews.freebsd.org/D8753 > > It's worth pointing out "discussed with" here very much does not mean > "approved by" =E2=80=94 several of the people mentioned above raised conc= erns > with this approach and only one person explicitly supported the > change. Sorry for my in precision, Approved by: pjd, emaste, ed, rwatson Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery Like I mention in a commit log there were some concerns. This is also the reason why I wouldn't commit it with only one 'go for it'. Thanks, Mariusz > > Best, > Conrad