Date: Mon, 25 Sep 2006 18:07:33 -0600 (MDT) From: Warren Block <wblock@wonkity.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/103653: [patch] Bug in p5-Number-Format Message-ID: <200609260007.k8Q07X85010330@speedy.wonkity.com> Resent-Message-ID: <200609260010.k8Q0AE0q068403@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 103653
>Category: ports
>Synopsis: [patch] Bug in p5-Number-Format
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Sep 26 00:10:14 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Warren Block
>Release: FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD speedy.wonkity.com 6.1-STABLE FreeBSD 6.1-STABLE #0: Wed Aug 30 19:06:32 MDT 2006 root@speedy.wonkity.com:/usr/obj/usr/src/sys/SPEEDY i386
>Description:
An extra single-quoted space is present on line 647 of Format.pm, causing a syntax
error when compiling the module. The space is not present in the current version 1.52 of
Format::Number on CPAN. Maybe this bug was fixed after the port was updated to 1.52?
>How-To-Repeat:
use Number::Format;
syntax error at /usr/local/lib/perl5/site_perl/5.8.8/Number/Format.pm line 648, near "("
>Fix:
The best fix would be to get the latest version of Format.pm from CPAN. This patch
fixes the only current difference, but other changes may happen.
--- /tmp/Format.pm Mon Sep 25 17:50:02 2006
+++ /usr/local/lib/perl5/site_perl/5.8.8/Number/Format.pm Mon Sep 25 17:50:10 2006
@@ -644,7 +644,7 @@
# Combine it all back together and return it.
$self->{int_curr_symbol} =~ s/\s*$/ /;
- my $result = ($self->{int_curr_symbol} . ' '
+ my $result = ($self->{int_curr_symbol} .
($precision ?
join($self->{mon_decimal_point}, $integer, $decimal) :
$integer));
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200609260007.k8Q07X85010330>