From owner-svn-src-all@freebsd.org  Tue Feb 12 16:21:19 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A34314EB865;
 Tue, 12 Feb 2019 16:21:19 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id ED7D46C6D9;
 Tue, 12 Feb 2019 16:21:18 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1CGL56q076679;
 Tue, 12 Feb 2019 08:21:05 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1CGL5dq076678;
 Tue, 12 Feb 2019 08:21:05 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs
In-Reply-To: <alpine.BSF.2.00.1902121808080.2716@woozle.rinet.ru>
To: Dmitry Morozovsky <marck@freebsd.org>
Date: Tue, 12 Feb 2019 08:21:05 -0800 (PST)
CC: Cy Schubert <Cy.Schubert@cschubert.com>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-stable@freebsd.org,
 svn-src-stable-12@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: ED7D46C6D9
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.96 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.997,0];
 NEURAL_HAM_SHORT(-0.96)[-0.961,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2019 16:21:19 -0000

> On Tue, 12 Feb 2019, Cy Schubert wrote:
> 
> > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry 
> > Morozovsky wr
> > ites:
> > > Author: marck (doc committer)
> > > Date: Tue Feb 12 13:58:16 2019
> > > New Revision: 344051
> > > URL: https://svnweb.freebsd.org/changeset/base/344051
> > >
> > > Log:
> > >   MFC 343548:
> > >   
> > >     Allow dashes as a valid character in UFS labels.
> > 
> > Approved by: Whom?
> 
> Sorry, I missed commit log metadata from the original change.
> 
> Lesson learnt.

I think your fine on how you did this, I certainly already
knew from reading the ^head commits that this change had
infact been approved by Kirk, and had been flagged for MFC.

I do not see value in duplicationg all that info in the
stable branches, but perhaps we should formalize that in
the committers guide on commit messages?

-- 
Rod Grimes                                                 rgrimes@freebsd.org