From owner-p4-projects@FreeBSD.ORG  Thu May 18 05:52:15 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8C69116A404; Thu, 18 May 2006 05:52:15 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5339E16A402
	for <perforce@freebsd.org>; Thu, 18 May 2006 05:52:15 +0000 (UTC)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 21DBD43D46
	for <perforce@freebsd.org>; Thu, 18 May 2006 05:52:15 +0000 (GMT)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4I5pp1u020593
	for <perforce@freebsd.org>; Thu, 18 May 2006 05:51:51 GMT
	(envelope-from kmacy@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4I5ppiO020590
	for perforce@freebsd.org; Thu, 18 May 2006 05:51:51 GMT
	(envelope-from kmacy@freebsd.org)
Date: Thu, 18 May 2006 05:51:51 GMT
Message-Id: <200605180551.k4I5ppiO020590@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	kmacy@freebsd.org using -f
From: Kip Macy <kmacy@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 97394 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 May 2006 05:52:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=97394

Change 97394 by kmacy@kmacy_storage:sun4v_rwbuf on 2006/05/18 05:51:04

	simplify initial invalidation when setting TSB

Affected files ...

.. //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 edit

Differences ...

==== //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#15 (text+ko) ====

@@ -166,12 +166,11 @@
 	tsb_index = (va >> tsb_shift) & TSB_MASK(tsb);
 	entry = (tte_t *)TLB_PHYS_TO_DIRECT(tsb->hvtsb_pa + 2*tsb_index*sizeof(uint64_t));
 	tte_tag = (ctx << TTARGET_CTX_SHIFT) | (va >> TTARGET_VA_SHIFT);
-	tte_data &= ~VTD_V;
 	/* store new value with valid bit cleared 
 	 * to avoid invalid intermediate value;
 	 */
-	*(entry + 1) = tte_data;
-	tte_data |= VTD_V;
+	*(entry + 1) = 0;
+	membar(StoreLoad);
 	*(entry) = tte_tag;
 	*(entry + 1) = tte_data;
 	membar(Sync);