From owner-svn-src-all@FreeBSD.ORG Thu Mar 24 01:32:04 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2416106564A; Thu, 24 Mar 2011 01:32:04 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [IPv6:2001:470:a803::1]) by mx1.freebsd.org (Postfix) with ESMTP id 33AF48FC13; Thu, 24 Mar 2011 01:32:04 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id C8BE1A800CE; Thu, 24 Mar 2011 09:32:02 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id mGGDQDItiEFE; Thu, 24 Mar 2011 09:31:52 +0800 (CST) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 44A5BA800C1; Thu, 24 Mar 2011 09:31:49 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=TVyYm+ZUX5MSB6rSFCvkpcYMxj8VByK/LfIh9lFqcC9jP63gSLyM6iNco9Xr7uVnh X66Mod35QMD5NNjRBC/5A== Message-ID: <4D8A9F02.6000408@delphij.net> Date: Wed, 23 Mar 2011 18:31:46 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110317 Thunderbird/3.1.9 ThunderBrowse/3.3.5 MIME-Version: 1.0 To: Alexander Best References: <201103232208.p2NM818d008805@svn.freebsd.org> <20110324002955.GA25594@freebsd.org> In-Reply-To: <20110324002955.GA25594@freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI Subject: Re: svn commit: r219939 - head/lib/libutil X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2011 01:32:04 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, On 03/23/11 17:29, Alexander Best wrote: > On Wed Mar 23 11, Xin LI wrote: >> Author: delphij >> Date: Wed Mar 23 22:08:01 2011 >> New Revision: 219939 >> URL: http://svn.freebsd.org/changeset/base/219939 >> >> Log: >> humanize_number(3) multiply the input number by 100, which could cause an >> integer overflow when the input is very large (for example, 100 Pi would >> become about 10 Ei which exceeded signed int64_t). > > i think we should also change the humanize_number(3) manual page accordingly. > here's a rough draft (date not bumped, yet). I think matching the variables within source code would not be necessary - -- I think it's much more clear to the reader of the manual page when the parameter called "number" and not "quotient" when the function is called "humanize_number". I am not sure about the CAVEATS part though, to me, it's kinda obvious since a parameter of signed int64_t can represent only a maximum number of INT64_MAX and a minimum number of INT64_MIN, and I think we don't document these explicitly for other manual pages. Personally I am inclined not to document this as limitation at all but would not object doing so. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJNip8CAAoJEATO+BI/yjfBz3YH/3YDlfvf8Bty6NeBnk3CyxjE skeaowGWIG5/gQ73zXfc1KTBEr5CobNLZWxuvGnXGCfMdATypRQR+5yQt366tQNK oDvd60tMofztH6rtrBt9b/td2mIoQAfX9Mc0X9ri69LgkExXVQBxqAcxkYxVadGm r+nAkhZjpaHdz20eDXbQg7wDXd3iGEBYx1wagMIBLtVeJL0GFKABXIHiZfbcBU9S tZNlXpeF3SXqOIql9KEeJ9+Zq8neU2sE7J1y3Jph4j8kkN39CABzNNKUHH7KLl7/ mD9mPKxILulDMkropntEU3G7uE2Y1Ax9o7PcjMbd509/bpzZK2SP4t28VSQg1/8= =ODAn -----END PGP SIGNATURE-----